Merged
Conversation
jeremybeard
requested review from
kushalmalani,
lzdanski and
neel-astro
as code owners
neel-astro
approved these changes
Dec 12, 2024
Contributor
neel-astro
left a comment
neel-astro
left a comment
There was a problem hiding this comment.
LGTM, left a minor nit around pkg/errors vs fmt.Errorf, but approving ahead of time,
| err = cmdExec(containerRuntime, stdout, stderr, []string{"start", "astro-pytest", "-a"}...) | ||
| if docErr != nil { | ||
| log.Debugf("Error starting pytest container: %s", docErr.Error()) | ||
| if err != nil { |
airflow/runtimes/docker_runtime.go
Outdated
| _, err = rt.Engine.Start() | ||
| if err != nil { | ||
| return fmt.Errorf(dockerOpenNotice) //nolint:stylecheck | ||
| return errors.New(dockerOpenNotice) |
Contributor
There was a problem hiding this comment.
nit: we should stay with fmt.Errorf I think, since pkg/errors is deprecated now, wdyt?
Contributor
Author
There was a problem hiding this comment.
I can change this instance from github.com/pkg/errors to errors?
We might want a separate cleanup PR at some point to remove github.com/pkg/errors completely from the CLI, I see many instances of it, and in ways that can't be transparently switched to errors.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change upgrades the golangci-lint dependency to the latest version so that it can support Go 1.23, which the CLI is also upgraded to. The corresponding linting errors are then also fixed.
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft