Introduction of sha_as_tag=True config in astro cli which will be used during Astro deploy#1752
Merged
neel-astro merged 8 commits intomainfrom Dec 11, 2024
Merged
Introduction of sha_as_tag=True config in astro cli which will be used during Astro deploy#1752neel-astro merged 8 commits intomainfrom
neel-astro merged 8 commits intomainfrom
Conversation
…d during astro deploy
rujhan-arora-astronomer
requested review from
jeremybeard,
kushalmalani and
neel-astro
as code owners
neel-astro
reviewed
Dec 10, 2024
Contributor
neel-astro
left a comment
neel-astro
left a comment
There was a problem hiding this comment.
Left a comment to squash, but looks ok otherwise
neel-astro
reviewed
Dec 11, 2024
Contributor
neel-astro
left a comment
neel-astro
left a comment
There was a problem hiding this comment.
Left final set of comments, but LGTM otherwise
neel-astro
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduction of sha_as_tag=True config in astro cli which will be used during Astro deploy.
astro deploy, using the sha digest when we make a call to the updateDeploymentImage endpoint in Houston, instead of the runtime version tag.🎟 Issue(s)
Related https://github.com/astronomer/issues/issues/6836
🧪 Functional Testing
Testing locally and on staging cluster too.
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft