Fixed the wrong API call being made when customer wants to fetch all deployments#1746
Merged
neel-astro merged 6 commits intomainfrom Dec 5, 2024
Merged
Fixed the wrong API call being made when customer wants to fetch all deployments#1746neel-astro merged 6 commits intomainfrom
neel-astro merged 6 commits intomainfrom
Conversation
rujhan-arora-astronomer
requested review from
jeremybeard,
kushalmalani and
neel-astro
as code owners
Contributor
Author
|
Gentle reminder @kushalmalani @jeremybeard @neel-astro |
jeremybeard
approved these changes
Nov 25, 2024
Contributor
jeremybeard
left a comment
jeremybeard
left a comment
There was a problem hiding this comment.
One nit comment but approving ahead of that
Contributor
Author
|
@jeremybeard Addressed the nitpick. Can you merge this too plz, thank you! |
neel-astro
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the wrong API call being made when a customer wants to fetch all deployments.
When a customer wants to fetch all deployments, the cli right now makes a call to an API which requires workspace ID. So, I am using another api instead which should return all the deployments.
🎟 Issue(s)
Related #6602
🧪 Functional Testing
Run astro deployment list --all. It should list all the deployments irrespective of workspace.
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft