Conversation
kushalmalani
reviewed
Aug 3, 2023
| @@ -536,8 +536,7 @@ func (d *DockerCompose) Pytest(pytestFile, customImageName, deployImageName, pyt | |||
|
|
|||
| func (d *DockerCompose) UpgradeTest(newAirflowVersion, deploymentID, newImageName, customImage string, conflictTest, versionTest, dagTest bool, client astro.Client) error { | |||
Contributor
There was a problem hiding this comment.
Can we remove conflictTest from the function too?
kushalmalani
approved these changes
Aug 3, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1336 +/- ##
==========================================
- Coverage 86.92% 86.92% -0.01%
==========================================
Files 114 114
Lines 13874 13872 -2
==========================================
- Hits 12060 12058 -2
Misses 1083 1083
Partials 731 731
☔ View full report in Codecov by Sentry. |
kushalmalani
pushed a commit
that referenced
this pull request
Aug 3, 2023
* remove conflict test * fix test
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove conflict test. Test currently finds a conflict with the latest version of runtime. This would be too confusing to users as there tests would fail and they would have no way to fix it
🎟 Issue(s)
Related #XXX
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft