Skip to content

CI: Fix uv.lock by removing coordinator distribution#1585

Merged
jason810496 merged 2 commits into
task-sdk/feature/coordinator-interfacefrom
task-sdk/feature/coordinator-interface-fix-uv-lock
May 18, 2026
Merged

CI: Fix uv.lock by removing coordinator distribution#1585
jason810496 merged 2 commits into
task-sdk/feature/coordinator-interfacefrom
task-sdk/feature/coordinator-interface-fix-uv-lock

Conversation

@jason810496

Copy link
Copy Markdown
Member

What

We should remove apache-airflow-coordinators-java uv member from root uv.lock.

@jason810496 jason810496 self-assigned this May 18, 2026
@jason810496 jason810496 requested a review from uranusjr May 18, 2026 11:56

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0f73cf062c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread uv.lock
@jason810496 jason810496 marked this pull request as draft May 18, 2026 12:10
@jason810496 jason810496 requested a review from Copilot May 18, 2026 12:10
@jason810496

Copy link
Copy Markdown
Member Author

@codex review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Cleanup PR following #1580 (which moved the coordinator implementation back into the SDK). Removes leftover references to the now-deleted apache-airflow-coordinators-java workspace member from the root uv.lock, pyproject.toml workspace members list, docker-compose test mount files, and the namespace-extending shim in task-sdk/src/airflow/sdk/__init__.py.

Changes:

  • Remove apache-airflow-coordinators-java from uv.lock members and its package entry.
  • Remove sdk/coordinators/java workspace member from root pyproject.toml.
  • Remove coordinator mount entries from docker-compose tests/remove sources YAMLs and drop the pkgutil.extend_path shim in airflow.sdk.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
uv.lock Drops the coordinator member and its package metadata block; incidental marker/wheel diffs from uv lock regeneration.
pyproject.toml Removes sdk/coordinators/java from workspace members.
scripts/ci/docker-compose/tests-sources.yml Removes coordinator tests bind mount.
scripts/ci/docker-compose/remove-sources.yml Removes coordinator src empty mount.
task-sdk/src/airflow/sdk/init.py Removes the pkgutil.extend_path namespace shim no longer needed after coordinator moved into SDK.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jason810496 jason810496 marked this pull request as ready for review May 18, 2026 13:04
@jason810496 jason810496 merged commit ebe061c into task-sdk/feature/coordinator-interface May 18, 2026
4 checks passed
@jason810496 jason810496 deleted the task-sdk/feature/coordinator-interface-fix-uv-lock branch May 18, 2026 13:04
jason810496 added a commit that referenced this pull request May 22, 2026
* CI: Fix uv.lock by removing coordinator distribution

* Remove the remaining entry catch by codex bot
jason810496 added a commit that referenced this pull request May 23, 2026
* CI: Fix uv.lock by removing coordinator distribution

* Remove the remaining entry catch by codex bot
jason810496 added a commit that referenced this pull request May 23, 2026
* CI: Fix uv.lock by removing coordinator distribution

* Remove the remaining entry catch by codex bot
uranusjr pushed a commit that referenced this pull request May 25, 2026
* CI: Fix uv.lock by removing coordinator distribution

* Remove the remaining entry catch by codex bot
uranusjr pushed a commit that referenced this pull request May 26, 2026
* CI: Fix uv.lock by removing coordinator distribution

* Remove the remaining entry catch by codex bot
uranusjr pushed a commit that referenced this pull request May 26, 2026
* CI: Fix uv.lock by removing coordinator distribution

* Remove the remaining entry catch by codex bot
uranusjr pushed a commit that referenced this pull request May 26, 2026
* CI: Fix uv.lock by removing coordinator distribution

* Remove the remaining entry catch by codex bot
uranusjr pushed a commit that referenced this pull request May 27, 2026
* CI: Fix uv.lock by removing coordinator distribution

* Remove the remaining entry catch by codex bot
uranusjr pushed a commit that referenced this pull request May 27, 2026
* CI: Fix uv.lock by removing coordinator distribution

* Remove the remaining entry catch by codex bot
uranusjr pushed a commit that referenced this pull request May 27, 2026
* CI: Fix uv.lock by removing coordinator distribution

* Remove the remaining entry catch by codex bot
uranusjr pushed a commit that referenced this pull request May 27, 2026
* CI: Fix uv.lock by removing coordinator distribution

* Remove the remaining entry catch by codex bot
uranusjr pushed a commit that referenced this pull request May 27, 2026
* CI: Fix uv.lock by removing coordinator distribution

* Remove the remaining entry catch by codex bot
uranusjr pushed a commit that referenced this pull request May 27, 2026
* CI: Fix uv.lock by removing coordinator distribution

* Remove the remaining entry catch by codex bot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants