Show "Warning" to Users with Duplicate Connections #1072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
approved these changes
Nov 23, 2020
|
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed! |
As written in apache#9067, Airflow 2.0 introduces a change that requires that all Airflow connections be unique (whereas Airflow 1.10.x technically supports two connections with the same name and potentially the same values). With this commit, we show "warning" in the Airflow UI for users with duplicate connections
kaxil
force-pushed
the
show-warning-dup-cons
branch
from
35aa514 to
dd027f1
Compare
kaxil
added a commit
that referenced
this pull request
Nov 25, 2020
As written in apache#9067, Airflow 2.0 introduces a change that requires that all Airflow connections be unique (whereas Airflow 1.10.x technically supports two connections with the same name and potentially the same values). With this commit, we show "warning" in the Airflow UI for users with duplicate connections
kaxil
added a commit
that referenced
this pull request
Dec 10, 2020
As written in apache#9067, Airflow 2.0 introduces a change that requires that all Airflow connections be unique (whereas Airflow 1.10.x technically supports two connections with the same name and potentially the same values). With this commit, we show "warning" in the Airflow UI for users with duplicate connections
drdenzy
pushed a commit
that referenced
this pull request
Jan 20, 2021
As written in apache#9067, Airflow 2.0 introduces a change that requires that all Airflow connections be unique (whereas Airflow 1.10.x technically supports two connections with the same name and potentially the same values). With this commit, we show "warning" in the Airflow UI for users with duplicate connections
kaxil
added a commit
that referenced
this pull request
Mar 15, 2021
As written in apache#9067, Airflow 2.0 introduces a change that requires that all Airflow connections be unique (whereas Airflow 1.10.x technically supports two connections with the same name and potentially the same values). With this commit, we show "warning" in the Airflow UI for users with duplicate connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As written in apache#9067, Airflow 2.0 introduces a change that
requires that all Airflow connections be unique (whereas Airflow 1.10.x
technically supports two connections with the same name and
potentially the same values).
With this commit, we show "warning" in the Airflow UI for users
with duplicate connections
Preview:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.