Repository navigation
Conversation
astrofrog
reviewed
Apr 24, 2020
| for i, ix in enumerate(self.mapping.mapping): | ||
| if out_shape[ix] != pixel_shape[i]: | ||
| raise ValueError( | ||
| "The pixel shapes of the supplied WCSes do not match for the dimensions shared by the supplied mapping.") |
Owner
There was a problem hiding this comment.
Shouldn't we validate this in the input to avoid doing this check every time this property is accessed? (same comment for pixel_bounds)
Collaborator
Author
There was a problem hiding this comment.
fair point, but that's basically doing to duplicate this whole property for what I can't imagine is going to be a big gain?
| The WCSes to combine | ||
| """ | ||
| def __init__(self, *wcs): | ||
| def __init__(self, *wcs, mapping=None): |
Owner
There was a problem hiding this comment.
Needs to be included in docstring above
| return tuple(world_arrays) | ||
|
|
||
| def world_to_pixel_values(self, *world_arrays): | ||
| # TODO: Decide on the behaviour here! |
Cadair
force-pushed
the
low-level-wcs-wrappers-shared-compound
branch
from
April 24, 2020 13:52
f4739fa to
ecf00e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defo needs more tests, but mainly we need to decide what the correct behaviour of
world_to_pixel_valuesis.