Skip to content

Draft wcsapi annotations - #155

Open
astrofrog wants to merge 3 commits into
mainfrom
wcsapi-type-annotations-draft
Open

Draft wcsapi annotations#155
astrofrog wants to merge 3 commits into
mainfrom
wcsapi-type-annotations-draft

Conversation

@astrofrog

@astrofrog astrofrog commented Sep 18, 2026

Copy link
Copy Markdown
Owner

Just a draft for self-review

eerovaher and others added 3 commits September 17, 2026 23:09
@eerovaher @astrofrog
Add basic Mypy configuration
d908510 
Configuring a default list of files for Mypy to check helps ensure that
modules without typing errors stay without typing errors. Configuring
`follow_imports = "silent"` ensures that Mypy does not report errors
from modules it is not instructed to check. In the long term type
checking with Mypy can allow compiling (parts of) `astropy` with Mypyc.
@eerovaher @astrofrog
Set up a CI job for Mypy
ada2f89 
The new CI job helps ensure that typing errors are not introduced to
modules Mypy already approves. Mypy approval is a requirement for
compiling anything with Mypyc.
@astrofrog
Add full type annotations to astropy.wcs.wcsapi and enable strict myp…
a8899fa 
…y checking for the subpackage with tests checked but not annotated
@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

testing wcs.wcsapi

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@astrofrog @eerovaher