Skip to content

Moving the multiband LS upstream #38

Closed

Description

@bsipocz

If I understand the status correctly, it's only the multiband LS that is unique in gatspy, the rest had been moved upstream to astropy a couple of years ago.

@jakevdp - how would you feel to move the multi band as well and maybe archive this repo? It would make somewhat easier to communicate to the community that all your astroML & gatspy implementations has been moved, and receive the maintenance and occasional fixes and improvements in astropy.timeseries rather than at multiple places?

I volunteer to do the actual moving bit, but it's one of those cases where it feels better to ask for permission and opinion first rather than forgiveness after the fact.

Activity

  1. jakevdp commented on Feb 25, 2020

    @jakevdp
    Member

    Sure, if the astropy community thinks the multiband code belongs upstream, I'd be fine with that.

  2. rhiannonlynne commented on Jan 3, 2023

    @rhiannonlynne

    Is this work underway? I would certainly use it, and I see that some of the community are considering opening a new work "NewGatspy" to continue updates/work on gatspy with needs ramping up as part of the LSST.

  3. bsipocz commented on Jan 3, 2023

    @bsipocz
    MemberAuthor

    Yes, the LINCC group is doing some of this upstreaming. PR is here: astropy/astropy#14016

  4. bsipocz commented on Mar 31, 2023

    @bsipocz
    MemberAuthor

    @dougbrn, could you comment on whether there is anything else left in this library, once the PR from above is merged? If not, I would propose to move all the open issues upstream, and archive the repo for now.

  5. dougbrn commented on Mar 31, 2023

    @dougbrn

    Yeah, the multiband lombscargle going into astropy has everything from gatspy's multiband lombscargle. As far as what is left in the gatspy overall, we didn't include some of the other multiband gatspy functions in the port, such as the Multiband SuperSmoother or the Multiband Template Fitter. So unless those were ported in other work, gatspy may still be the only home for them.

  6. bsipocz commented on Mar 31, 2023

    @bsipocz
    MemberAuthor

    It would be lovely to see them being ported over, too, so everything is at one place.

  7. bsipocz commented on May 8, 2023

    @bsipocz
    MemberAuthor

    I suppose as all stuff gets moved out from here, we should move the datasets/fetch_... functions upstream to astroml/astroml?

  8. bsipocz commented on Sep 3, 2025

    @bsipocz
    MemberAuthor

    Given the comment #38 (comment) above, I'm closing this issue now. The moving of the supersmoother upstream has the astropy issue already, there is no need for multiple open issues for the same thing then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions