fix(conductor): add explicit TLS config#2140
Merged
mycodecrafting merged 3 commits intomainfrom Apr 30, 2025
Merged
Conversation
mycodecrafting
requested review from
SuperFluffy,
ethanoroshiba and
joroshiba
as code owners
joroshiba
approved these changes
Apr 28, 2025
Member
|
Would be good to get a changelog entry w/ info on the fix. |
SuperFluffy
reviewed
Apr 28, 2025
| .wrap_err("failed parsing provided string as Uri")?; | ||
| let endpoint = Endpoint::from(uri.clone()); | ||
| let mut endpoint = Endpoint::from(uri.clone()); | ||
| if uri.scheme() == Some(&http::uri::Scheme::HTTPS) { |
Contributor
There was a problem hiding this comment.
Is this necessary? Would setting the tls config preclude us from using http? I think we should be able to still connect (just like before)?
Either way, if this does blockhttp, I think I'd prefer to have ane explicit flag that deactivates tls so that one doesn't accidentally provide http instead of https and risk exposing the service to an unchecked endpoint.
Contributor
Author
There was a problem hiding this comment.
good point, I don't believe the TLS config prevents using http. Should not
| let endpoint = Endpoint::from(uri.clone()); | ||
| let mut endpoint = Endpoint::from(uri.clone()); | ||
| if uri.scheme() == Some(&http::uri::Scheme::HTTPS) { | ||
| endpoint = endpoint.tls_config(ClientTlsConfig::new().with_enabled_roots())?; |
Contributor
There was a problem hiding this comment.
This is missing error context. Report that you failed to set the tls config using wrap_err
SuperFluffy
approved these changes
Apr 29, 2025
Contributor
SuperFluffy
left a comment
SuperFluffy
left a comment
There was a problem hiding this comment.
Looks good. But seconding @joroshiba: let's add an entry to the changelog.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 20, 2025
## Summary Tag Conductor with v2.0.0-rc.2 that contains TLS fixes. ## Background Contains #2140 --------- Co-authored-by: Jordan Oroshiba <[email protected]>
ethanoroshiba
pushed a commit
that referenced
this pull request
May 27, 2025
## Summary Tag Conductor with v2.0.0-rc.2 that contains TLS fixes. ## Background Contains #2140 --------- Co-authored-by: Jordan Oroshiba <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
## Summary Add explicit TLS config for composer's sequencer connection ## Background Tonic [removed implicit TLS configs](hyperium/tonic#1731) in v0.12.0 which now causes TLS errors when composer tries to connect to a remote sequencer network over TLS. ## Changelogs Changelogs updated. ## Related Issues Similar to fix done for conductor in [PR #2140](#2140)
sgranfield4403-3
added a commit
to sgranfield4403-3/astria
that referenced
this pull request
Oct 2, 2025
## Summary Tag Conductor with v2.0.0-rc.2 that contains TLS fixes. ## Background Contains astriaorg/astria#2140 --------- Co-authored-by: Jordan Oroshiba <[email protected]>
sgranfield4403-3
added a commit
to sgranfield4403-3/astria
that referenced
this pull request
Oct 2, 2025
## Summary Add explicit TLS config for composer's sequencer connection ## Background Tonic [removed implicit TLS configs](hyperium/tonic#1731) in v0.12.0 which now causes TLS errors when composer tries to connect to a remote sequencer network over TLS. ## Changelogs Changelogs updated. ## Related Issues Similar to fix done for conductor in [PR #2140](astriaorg/astria#2140)
AngieD101
added a commit
to AngieD101/astria
that referenced
this pull request
Oct 10, 2025
## Summary Tag Conductor with v2.0.0-rc.2 that contains TLS fixes. ## Background Contains astriaorg/astria#2140 --------- Co-authored-by: Jordan Oroshiba <[email protected]>
AngieD101
added a commit
to AngieD101/astria
that referenced
this pull request
Oct 10, 2025
## Summary Add explicit TLS config for composer's sequencer connection ## Background Tonic [removed implicit TLS configs](hyperium/tonic#1731) in v0.12.0 which now causes TLS errors when composer tries to connect to a remote sequencer network over TLS. ## Changelogs Changelogs updated. ## Related Issues Similar to fix done for conductor in [PR #2140](astriaorg/astria#2140)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add explicit TLS config for conductor when the sequencer url is https
Background
Tonic removed implicit TLS configs in v0.12.0 which now causes TLS errors when conductor tries to connect to a remote sequencer network over TLS.