Repository navigation
Conversation
zaniebot
force-pushed
the
zb/disable-release-caches
branch
from
August 17, 2026 17:01
728182b to
0c2c610
Compare
This was referenced Aug 17, 2026
zaniebot
force-pushed
the
zb/disable-release-caches
branch
from
August 17, 2026 17:41
9524b25 to
0c2c610
Compare
zanieb
marked this pull request as ready for review
August 17, 2026 17:44
|
Promoted to #21168. |
zanieb
added a commit
to astral-sh/uv
that referenced
this pull request
Aug 18, 2026
Trusted release actions must not accidentally restore a poisoned shared GitHub cache. Set `ACTIONS_CACHE_MODE: none` in `release.yml` and each reusable workflow it calls so clients that support the variable skip cache reads and writes. Each reusable workflow needs its own setting because workflow-level environment variables do not propagate to called workflows. The shared binary-build workflow uses the same cache-disabled setting when invoked by CI. This is a cooperative client-side default, not token revocation or server-enforced denial. Older or independent clients, or code calling the cache API directly, can still access the service. The `@actions/cache` library's [6.2.0 change](actions/toolkit#2447) skips operations before contacting the cache backend; that is separate from its handling of server-denied requests. The release graph uses `[email protected]` and `[email protected]`, whose pinned [setup-uv](https://github.com/astral-sh/setup-uv/blob/20cfd1bf945f4377ade1205e4dbc17946fc9a30d/package-lock.json) and [setup-python](https://github.com/actions/setup-python/blob/5fda3b95a4ea91299a34e894583c3862153e4b97/package-lock.json) dependencies include `@actions/[email protected]`. Both honor this variable. The separate `actions/[email protected]` action still bundles `@actions/[email protected]` and does not honor it; the release graph does not invoke that action directly. Stacked on astral-sh#761, which keeps the action-specific opt-outs, removes the docs Rust cache, and explicitly disables maturin's sccache integration. `release-prepare.yml`, same-run artifacts, and Depot's own cache are unchanged. Co-authored-by: Zanie Blue <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release workflows can restore shared GitHub caches through the docs Rust cache and
setup-uv's automatic caching. Remove the docs Rust cache and explicitly disable caching in every release invocation ofsetup-uv,setup-python, andmaturin-action. The shared binary-build workflow also keepssetup-uvcaching off when invoked by CI.release-prepare.yml, same-run artifacts, and Depot's own cache are unchanged. This configures the known cache clients; it does not revoke cache-service access.