uv build: Catch version mismatch between sdist and wheel #9633
Merged
Conversation
When building a wheel from a source distribution or both a source distribution and a wheel, the versions in their filenames must be the same. Note that we're not yet checking that also the `pyproject.toml`, if declared, matches.
konstin
added
the
enhancement
konstin
commented
Dec 4, 2024
Comment on lines
+83
to
+86
| #[error("The built source distribution has an invalid filename")] | ||
| InvalidBuiltSourceDistFilename(#[source] uv_distribution_filename::SourceDistFilenameError), | ||
| #[error("The built wheel has an invalid filename")] | ||
| InvalidBuiltWheelFilename(#[source] uv_distribution_filename::WheelFilenameError), |
Member
Author
There was a problem hiding this comment.
Add some extra context because it's not the input filename that's wrong, it's the output filename
charliermarsh
approved these changes
Dec 4, 2024
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Dec 9, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.6` -> `0.5.7` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.5.7`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#057) [Compare Source](astral-sh/uv@0.5.6...0.5.7) ##### Enhancements - Ignore dynamic version in source dist ([#​9549](astral-sh/uv#9549)) - Improve build frontend error handling ([#​9611](astral-sh/uv#9611)) - Un-hide `uv build --no-build-logs` option ([#​9642](astral-sh/uv#9642)) - Flag version mismatch between sdist and wheel during `uv build` ([#​9633](astral-sh/uv#9633)) - Improve message when updater receipt is for a different uv executable ([#​9487](astral-sh/uv#9487)) - Add environment variable to disable writing installer metadata files ([#​8877](astral-sh/uv#8877)) - Add managed downloads for the latest CPython releases: `3.9.21`, `3.10.16`, `3.11.11`, `3.12.8`, and `3.13.1` ([#​9696](astral-sh/uv#9696)) ##### Preview features - Build backend: Add hint on import with preview disabled ([#​9691](astral-sh/uv#9691)) - Build backend: Add direct builds to the resolver and installer ([#​9621](astral-sh/uv#9621)) - Build backend: Add integration test for scripts ([#​9635](astral-sh/uv#9635)) - Build backend: Add template to `uv init` ([#​9661](astral-sh/uv#9661)) - Build backend: Add `--list` option ([#​9610](astral-sh/uv#9610)) ##### Bug fixes - Create missing parent directories for output file of `uv export` / `uv pip compile` ([#​9648](astral-sh/uv#9648)) - Fix missing display of non-freethreaded Python 3.13 in `python list` ([#​9669](astral-sh/uv#9669)) - Implement `Ord` and `PartialOrd` without origin for `Requirement` ([#​9624](astral-sh/uv#9624)) - Include more sources to avoid lowest bound warning ([#​9644](astral-sh/uv#9644)) - Respect build tag priority in `uv.lock` ([#​9677](astral-sh/uv#9677)) ##### Documentation - Add `build-essentials` note to build failures doc ([#​9641](astral-sh/uv#9641)) - Add entry-point for distroless image in GitLab documentation ([#​9093](astral-sh/uv#9093)) - Add documentation for `uv python pin` without a `REQUEST` argument ([#​9631](astral-sh/uv#9631)) - Add a link to `uv python pin` reference docs ([#​9630](astral-sh/uv#9630)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building a wheel from a source distribution or both a source distribution and a wheel, the versions in their filenames must be the same.
By inspecting the filenames, we also assert that the filenames from the build a valid (we don't enforce normalization though, just that uv can parse them).
Note that we're not yet checking that also the
pyproject.tomlversion, if declared, and METADATA version matches.