Conversation
charliermarsh
added
the
internal
charliermarsh
force-pushed
the
charlie/rust-1.83
branch
2 times, most recently
from
66b147b to
1bfd24d
Compare
charliermarsh
force-pushed
the
charlie/rust-1.83
branch
from
1bfd24d to
41d1c74
Compare
konstin
approved these changes
Nov 29, 2024
| if let Err(err) = rename_with_retry(extracted, target).await { | ||
| // If the directory already exists, accept it. | ||
| if target.is_dir() { | ||
| if err.kind() == std::io::ErrorKind::AlreadyExists { |
Comment on lines
-1168
to
+1170
| if !components | ||
| if components | ||
| .next() | ||
| .is_some_and(|component| component.as_os_str() == "WindowsApps") | ||
| .is_none_or(|component| component.as_os_str() != "WindowsApps") |
zanieb
added a commit
that referenced
this pull request
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A lot of good new lints, and most importantly, error stabilizations. I tried to find a few usages of the new stabilizations, but I'm sure there are more.
IIUC, this does require bumping our MSRV.