Include Git member information when getting metadata from cache by ericmarkmartin · Pull Request #9388 · astral-sh/uv

ericmarkmartin · 2024-11-23T16:51:11Z

Summary

Include the git_member when fetching metadata from cache.

h/t to @PhilipVinc for the suggested fix

Resolves #8887

Test Plan

Pending

ericmarkmartin · 2024-11-23T17:09:38Z

It looks like some of the failing tests are the "too many requests" thing I alluded to in my comment on the issue

charliermarsh · 2024-11-23T17:10:14Z

Yeah I think something is up with that index. I should look into removing our dependency on it.

charliermarsh

This seems right, but is there a way to test it?

ericmarkmartin · 2024-11-24T05:19:09Z

This seems right, but is there a way to test it?

Could we set up a packse like the example given in the issue (see https://github.com/PhilipVinc/uvtest/tree/dab673b4ad5c6f1335c491baf49ad4965562e876)?

Also, I generally am pretty clueless about uv's testing story (I know it's snapshot based, but that's about it) but would be eager to learn by writing some tests here

zanieb · 2024-11-25T23:23:35Z

If it would help we could add a repository in our test org, e.g. https://github.com/astral-test/uv-submodule-pypackage

I'm not sure I understand the issue here though.

ericmarkmartin · 2024-11-26T00:56:01Z

If it would help we could add a repository in our test org, e.g. https://github.com/astral-test/uv-submodule-pypackage

That could be helpful. I take it that'd be easier than getting packse to serve git repos? One maybe relevant question here is whether we can use git+ with file-scheme urls?

zanieb · 2024-11-26T01:13:23Z

I take it that'd be easier than getting packse to serve git repos?

Yeah this would probably be a pain.

One maybe relevant question here is whether we can use git+ with file-scheme urls?

I don't quite follow, perhaps you should tell me what a test case would look like given a uv binary and I can help construct it? Perhaps as an answer to your question, a test could just clone a repository to a temporary directory then pass that path to uv?

ericmarkmartin · 2024-11-26T01:50:07Z

Perhaps as an answer to your question, a test could just clone a repository to a temporary directory then pass that path to uv?

For sure, I just wasn't at my computer earlier. I just confirmed that using git+ with file:// urls works, though unfortunately testing this with @PhilpVinc's test repository (see linked issue) had the conflicting URL issue reoccur 😞

konstin · 2024-11-26T21:06:05Z

If you need inspiration for tests, there are transitive_dep_in_git_workspace_no_root and transitive_dep_in_git_workspace_with_root from previous bug fixes in the area

charliermarsh · 2024-12-02T14:09:47Z

I'd like to get this merged today so we can release it. I'll add a test if needed.

ericmarkmartin · 2024-12-02T16:39:36Z

I'd like to get this merged today so we can release it. I'll add a test if needed.

Hey, Apologies for not getting to this, I had to get ready for a vacation. I’m out of the country without my personal computer right now so I think the chances I can do this today are pretty low.

charliermarsh · 2024-12-03T04:30:58Z

@ericmarkmartin -- No problem at all!

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.5` -> `0.5.6` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.5.6`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#056) [Compare Source](astral-sh/uv@0.5.5...0.5.6) ##### Enhancements - Add `--dry-run` to `uv pip uninstall` ([#9557](astral-sh/uv#9557)) - Allow `--constraints` and `--overrides` in `uv tool install` ([#9547](astral-sh/uv#9547)) - Display removed Python executables on uninstall ([#9459](astral-sh/uv#9459)) - Warn when keyring has no password for `uv publish` ([#8827](astral-sh/uv#8827)) - Add suggested action when `.python-version` pin is incompatible with the project ([#9590](astral-sh/uv#9590)) - Improve error messages for mismatches in `tool.uv.sources` ([#9482](astral-sh/uv#9482)) - Use constraints in trace rather than irrelevant `requires-python` ([#9529](astral-sh/uv#9529)) ##### Preview features - Add `uv python install --default` ([#8650](astral-sh/uv#8650)) - Fix Python executable installation when multiple patch versions are requested ([#9607](astral-sh/uv#9607)) - Build backend: Revamp `include` / `exclude` ([#9525](astral-sh/uv#9525)) - Build backend: Add fast path ([#9556](astral-sh/uv#9556)) - Build backend: Add functions to collect file list ([#9602](astral-sh/uv#9602)) - Build backend: Default excludes ([#9552](astral-sh/uv#9552)) - Build backend: Refactoring before list ([#9558](astral-sh/uv#9558)) - Build backend: Warn when visiting over 10k files ([#9523](astral-sh/uv#9523)) ##### Configuration - Make `check-url` available in configuration files ([#9032](astral-sh/uv#9032)) ##### Performance - Avoid adding non-extra package with extra dependencies ([#9540](astral-sh/uv#9540)) - Avoid cloning `String` in marker evaluation ([#9598](astral-sh/uv#9598)) ##### Rust API - `uv-pep508`: Add more methods for simplifying `extra`-related expressions ([#9469](astral-sh/uv#9469)) ##### Bug fixes - Allow `file:` URLs to include package names ([#9493](astral-sh/uv#9493)) - Avoid using IDs across PubGrub states ([#9538](astral-sh/uv#9538)) - Consistently enforce requested-vs.-built metadata when retrieving wheels ([#9484](astral-sh/uv#9484)) - Do not show empty version specifier in `uv tool list` ([#9605](astral-sh/uv#9605)) - Include Git member information when getting metadata from cache ([#9388](astral-sh/uv#9388)) - Include base installation directory in uv run PATH ([#9585](astral-sh/uv#9585)) - Insert backslash when appending to system drive ([#9488](astral-sh/uv#9488)) - Normalize paths when lowering Git dependencies ([#9595](astral-sh/uv#9595)) - Omit origin when comparing requirements ([#9570](astral-sh/uv#9570)) - Override `manylinux_compatible` with `--python-platform` ([#9526](astral-sh/uv#9526)) - Pass extra when evaluating lockfile markers ([#9539](astral-sh/uv#9539)) - Propagate markers for recursive extras in resolver ([#9509](astral-sh/uv#9509)) - Respect path dependencies within Git dependencies ([#9594](astral-sh/uv#9594)) - Support recursive extras with marker in `pip compile -r pyproject.toml` ([#9535](astral-sh/uv#9535)) - Don't emit unpinned warning for proxy packages ([#9497](astral-sh/uv#9497)) - Fix `--refresh-package` flag mentioned as `--refresh-dependency` ([#9486](astral-sh/uv#9486)) - Handle Windows AV/EDR file locks during script installations ([#9543](astral-sh/uv#9543)) - Re-enable conflicting extra/group tests and fix regression from [#9540](astral-sh/uv#9540) ([#9582](astral-sh/uv#9582)) ##### Documentation - Add missing word to docs for `run.md` ([#9527](astral-sh/uv#9527)) - Add policies reference section and license document ([#9367](astral-sh/uv#9367)) - Fix typo in entry point docs ([#9491](astral-sh/uv#9491)) - Fix up version in prior uninstall instructions ([#9485](astral-sh/uv#9485)) - Mention `uv pip` behavior in build system note ([#9586](astral-sh/uv#9586)) - Update build failures document ([#9584](astral-sh/uv#9584)) - Correct wording for multiple sources section ([#9504](astral-sh/uv#9504)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

include git_member when getting metadata from cache

26b65da

ericmarkmartin mentioned this pull request Nov 23, 2024

uv add workspace fails misteriously from git but not locally #8887

Closed

charliermarsh approved these changes Nov 24, 2024

View reviewed changes

charliermarsh requested a review from konstin November 24, 2024 02:00

charliermarsh added the bug Something isn't working label Nov 24, 2024

include git_member when building metadata from soruce

d6a44a8

charliermarsh mentioned this pull request Nov 29, 2024

Adding Git repo at subdirectory that points to source in same repo does not work #9516

Closed

Merge branch 'main' into git-cached-metadata

834c4e7

charliermarsh force-pushed the git-cached-metadata branch from 0df4984 to 5b82d90 Compare December 3, 2024 04:52

charliermarsh enabled auto-merge (squash) December 3, 2024 04:52

charliermarsh changed the title ~~include git_member when getting metadata from cache~~ Include Git member information when getting metadata from cache Dec 3, 2024

charliermarsh disabled auto-merge December 3, 2024 04:53

charliermarsh enabled auto-merge (squash) December 3, 2024 04:53

Add failing test

3f12e5d

charliermarsh force-pushed the git-cached-metadata branch from 5b82d90 to 3f12e5d Compare December 3, 2024 04:57

charliermarsh merged commit 16ca0c3 into astral-sh:main Dec 3, 2024

BrewTestBot mentioned this pull request Dec 3, 2024

uv 0.5.6 Homebrew/homebrew-core#199944

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Include Git member information when getting metadata from cache#9388

Include Git member information when getting metadata from cache#9388
charliermarsh merged 4 commits intoastral-sh:mainfrom
ericmarkmartin:git-cached-metadata

ericmarkmartin commented Nov 23, 2024 •

edited

Loading

Uh oh!

ericmarkmartin commented Nov 23, 2024 •

edited

Loading

Uh oh!

charliermarsh commented Nov 23, 2024

Uh oh!

charliermarsh left a comment

Uh oh!

ericmarkmartin commented Nov 24, 2024

Uh oh!

zanieb commented Nov 25, 2024

Uh oh!

ericmarkmartin commented Nov 26, 2024

Uh oh!

zanieb commented Nov 26, 2024

Uh oh!

ericmarkmartin commented Nov 26, 2024 •

edited

Loading

Uh oh!

konstin commented Nov 26, 2024

Uh oh!

charliermarsh commented Dec 2, 2024

Uh oh!

ericmarkmartin commented Dec 2, 2024 via email •

edited

Loading

Uh oh!

charliermarsh commented Dec 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

ericmarkmartin commented Nov 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

ericmarkmartin commented Nov 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

charliermarsh commented Nov 23, 2024

Uh oh!

charliermarsh left a comment

Choose a reason for hiding this comment

Uh oh!

ericmarkmartin commented Nov 24, 2024

Uh oh!

zanieb commented Nov 25, 2024

Uh oh!

ericmarkmartin commented Nov 26, 2024

Uh oh!

zanieb commented Nov 26, 2024

Uh oh!

ericmarkmartin commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

konstin commented Nov 26, 2024

Uh oh!

charliermarsh commented Dec 2, 2024

Uh oh!

ericmarkmartin commented Dec 2, 2024 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

charliermarsh commented Dec 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ericmarkmartin commented Nov 23, 2024 •

edited

Loading

ericmarkmartin commented Nov 23, 2024 •

edited

Loading

ericmarkmartin commented Nov 26, 2024 •

edited

Loading

ericmarkmartin commented Dec 2, 2024 via email •

edited

Loading