Fix get_operating_system_and_architecture#9319
Merged
charliermarsh merged 1 commit intoastral-sh:mainfrom Nov 21, 2024
Merged
Conversation
_get_glibc_version() can after astral-sh#9005 return either (0, 0) if glibc string is missing or (-1, -1) if the string can't be parsed. There was no need to change missing string to (0, 0). Also, move back indentation to make it easier to understand.
| version_str = _glibc_version_string() | ||
| if version_str is None: | ||
| return (0, 0) | ||
| return (-1, -1) |
Member
There was a problem hiding this comment.
Yeah I don't think this should have changed. \cc @konstin
Member
There was a problem hiding this comment.
(In part because this is vendored.)
Collaborator
There was a problem hiding this comment.
Yea, I implied that on my comment in the PR but I wasn't clear enough.
charliermarsh
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_get_glibc_version() can after #9005 return either (0, 0) if glibc
string is missing or (-1, -1) if the string can't be parsed. There was
no need to change missing string to (0, 0).
Also, move back indentation to make it easier to understand.