Clarify exclude-newer only allows full timestamps in settings docs#9135
Merged
BurntSushi merged 2 commits intoastral-sh:mainfrom Jan 6, 2025
Merged
Clarify exclude-newer only allows full timestamps in settings docs#9135BurntSushi merged 2 commits intoastral-sh:mainfrom
BurntSushi merged 2 commits intoastral-sh:mainfrom
Conversation
BurntSushi
requested changes
Dec 21, 2024
Member
BurntSushi
left a comment
BurntSushi
left a comment
There was a problem hiding this comment.
So I think this mostly looks good to me, but uv does technically accept a superset of RFC 3339. I think we should still say RFC 3339 because that's what most users know, but the reality is actually an amalgamation of RFC 3339, RFC 9557 and ISO 8601. (Where the precise details are specified by Temporal's ISO 8601 grammar.)
For example, --exclude-newer '2024-06-19T15:22:45-04[America/New_York]' is valid and perfectly cromulent despite it not being RFC 3339.
But saying "Temporal's ISO 8601 format" is probably not meaningful to most end users.
So for now, I think just saying "accepts a superset of RFC 3339" is fine. That's what most users will want. So just a small tweak in the wording. :)
Contributor
Author
|
@BurntSushi thanks for the feedback! I tweaked the wording. Would it be useful to link to the Temporal grammar in the superset? E.g., |
BurntSushi
approved these changes
Jan 6, 2025
Member
BurntSushi
left a comment
BurntSushi
left a comment
There was a problem hiding this comment.
This LGTM. I might suggest waiting on linking to Temporal until we have a more stable link for it (which will probably happen once it's officially part of ECMAScript.)
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jan 8, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.14` -> `0.5.15` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.5.15`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0515) [Compare Source](astral-sh/uv@0.5.14...0.5.15) ##### Python The managed Python distributions have been updated, including: - Python 3.14.0a3 support on macOS and Linux - Performance improvements - Fixes to SQLite feature detection See the [`python-build-standalone` release notes](https://github.com/astral-sh/python-build-standalone/releases/tag/20250106) for more details. ##### Enhancements - Respect `FORCE_COLOR` environment variable ([#​10315](astral-sh/uv#10315)) ##### Performance - Avoid generating unused hashes during `uv lock` ([#​10307](astral-sh/uv#10307)) - Visit source distributions before wheels ([#​10291](astral-sh/uv#10291)) ##### Bug fixes - Avoid downgrading packages when `--upgrade` is provided ([#​10097](astral-sh/uv#10097)) - Extract supported architectures from wheel tags ([#​10179](astral-sh/uv#10179)) - Redact new index credentials in `uv add` ([#​10329](astral-sh/uv#10329)) ##### Documentation - Clarify `exclude-newer` only allows full timestamps in settings documentation ([#​9135](astral-sh/uv#9135)) - Tweak script `--no-project` comment ([#​10331](astral-sh/uv#10331)) - Update copyright year ([#​10297](astral-sh/uv#10297)) - Add instructinos for installing with Scoop ([#​10332](astral-sh/uv#10332)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45MS4yIiwidXBkYXRlZEluVmVyIjoiMzkuOTEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #8553
Clarifies that the
exclude-newersetting must be a full timestamp and not a date.Test Plan
N/A