Error when --group includes non-existent groups#8394
Merged
charliermarsh merged 1 commit intotracking/735from Oct 22, 2024
Merged
Error when --group includes non-existent groups#8394charliermarsh merged 1 commit intotracking/735from
charliermarsh merged 1 commit intotracking/735from
Conversation
charliermarsh
force-pushed
the
charlie/error-groups
branch
2 times, most recently
from
386c7e6 to
26e9cf2
Compare
charliermarsh
commented
Oct 20, 2024
crates/uv-resolver/src/lock/mod.rs
Outdated
|
|
||
| // Validate any requested dependency groups. | ||
| for group in dev.groups().iter() { | ||
| if !root.metadata.requires_dev.contains_key(group) { |
Member
Author
There was a problem hiding this comment.
I don't love using metadata here (rather than root.dev_dependencies) because this metadata is mostly just intended for lockfile validation / caching (we invalidate the lockfile when the metadata changes). But if we use root.dev_dependencies, we will also fail if the user does --group foo when foo is empty. It seems wrong to fail when requesting a valid but empty group, so...
charliermarsh
force-pushed
the
charlie/error-groups
branch
from
26e9cf2 to
9d813ad
Compare
Merged
zanieb
reviewed
Oct 21, 2024
zanieb
approved these changes
Oct 21, 2024
charliermarsh
force-pushed
the
tracking/735
branch
from
bb83978 to
c246fbf
Compare
charliermarsh
force-pushed
the
charlie/error-groups
branch
2 times, most recently
from
64045ed to
07b5f8c
Compare
charliermarsh
force-pushed
the
charlie/error-groups
branch
from
07b5f8c to
417ecad
Compare
charliermarsh
added a commit
that referenced
this pull request
Oct 22, 2024
## Summary Part of #8272.
charliermarsh
added a commit
that referenced
this pull request
Oct 23, 2024
## Summary Part of #8272.
charliermarsh
added a commit
that referenced
this pull request
Oct 25, 2024
## Summary Part of #8272.
charliermarsh
added a commit
that referenced
this pull request
Oct 25, 2024
## Summary Part of #8272.
charliermarsh
added a commit
that referenced
this pull request
Oct 25, 2024
## Summary Part of #8272.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #8272.