Skip to content

Comments

Add uv build --no-build-logs to silence the build backend logs#7675

Merged
zanieb merged 3 commits intomainfrom
zb/build-no-output
Sep 26, 2024
Merged

Add uv build --no-build-logs to silence the build backend logs#7675
zanieb merged 3 commits intomainfrom
zb/build-no-output

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Sep 24, 2024

Extends #7674

The build backend can be pretty verbose, it seems nice to be able to turn that off?

@zanieb zanieb added the cli Related to the command line interface label Sep 24, 2024
@charliermarsh
Copy link
Member

This necessary given #7674? I'm just wary of adding more command-line flags without strong motivation.

Base automatically changed from zb/build-quiet to main September 25, 2024 13:23
@zanieb
Copy link
Member Author

zanieb commented Sep 25, 2024

They're pretty distinct i.e. I want to be able to share the output of the command in the docs but the build backend output is a lot on a trivial project. Maybe this will be solved by #3957 ?

@charliermarsh
Copy link
Member

Can you just use a ... or similar in the docs? I guess I just don't see this as very useful in practice.

@zanieb zanieb marked this pull request as draft September 25, 2024 13:53
@zanieb
Copy link
Member Author

zanieb commented Sep 25, 2024

Humph... easy enough to revisit if we need it later.

@charliermarsh
Copy link
Member

Want to reopen? I somewhat prefer --no-build-output so that it doesn't require users to know what a "backend" is, but understand that uv build --no-build-output may be awkward.

@charliermarsh charliermarsh reopened this Sep 26, 2024
@charliermarsh charliermarsh marked this pull request as ready for review September 26, 2024 23:22
@zanieb
Copy link
Member Author

zanieb commented Sep 26, 2024

Want to reopen? I somewhat prefer --no-build-output so that it doesn't require users to know what a "backend" is, but understand that uv build --no-build-output may be awkward.

I felt the same thing and went back and forth. I figured it'd be better to be explicit since we don't foresee it being used by beginners? But --no-build-output sort of makes sense still... hm.

@zanieb zanieb changed the title Add uv build --no-backend-output to silence the build backend logs Add uv build --no-build-logs to silence the build backend logs Sep 26, 2024
@zanieb zanieb enabled auto-merge (squash) September 26, 2024 23:37
@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Sep 26, 2024
@zanieb zanieb merged commit ed1684a into main Sep 26, 2024
@zanieb zanieb deleted the zb/build-no-output branch September 26, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Related to the command line interface internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants