Use placeholder for virtual environment activation bin filter#7530
Merged
Use placeholder for virtual environment activation bin filter#7530
Conversation
zanieb
force-pushed
the
zb/bin-filter
branch
2 times, most recently
from
85ce091 to
08dff48
Compare
zanieb
force-pushed
the
zb/bin-filter
branch
from
08dff48 to
4dfeb88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's best practice to use a placeholder when we transform something, and #7522 is having snapshot issues because this filter conflicts with
with_filtered_virtualenv_bin