Implement `uv build` by charliermarsh · Pull Request #6895 · astral-sh/uv

charliermarsh · 2024-08-31T17:53:54Z

Summary

This PR exposes uv's PEP 517 implementation via a uv build frontend, such that you can use uv build to build source and binary distributions (i.e., wheels and sdists) from a given directory.

There are some TODOs that I'll tackle in separate PRs:

Support building a wheel from a source distribution (rather than from source) (Support uv build --wheel from source distributions #6898)
Stream the build output (Show build output by default in uv build #6912)

Closes #1510

Closes #1663.

charliermarsh · 2024-08-31T18:40:34Z

I will do a pass on the docs once the interface gets the green light.

charliermarsh · 2024-09-01T16:10:06Z

I plan to show build output in a later PR.

crates/uv/tests/build.rs

crates/uv-cli/src/lib.rs

konstin · 2024-09-02T08:22:25Z

crates/uv/src/commands/build.rs

+    )
+    .await?;
+
+    match assets {


Should we should the relative path here instead of the filename?

konstin · 2024-09-02T08:24:20Z

crates/uv/src/commands/build.rs

+        (true, false) => BuildPlan::Sdist,
+        (false, true) => BuildPlan::Wheel,
+        (true, true) => BuildPlan::SdistAndWheel,
+    };


We should explain this behavior in the cli docs

crates/uv-client/src/base_client.rs

crates/uv/src/commands/build.rs

konstin · 2024-09-02T08:45:11Z

Should uv build build the entire workspace or only the current package?

zanieb · 2024-09-03T18:53:09Z

I would imagine building the entire workspace by default and --package to select a specific one?

charliermarsh · 2024-09-03T18:56:14Z

I’d prefer to tackle any workspace integration in a separate PR. How would that intersect with the ability to pass a single source dist file? Or the ability to pass a path to a directory?

crates/uv-cli/src/lib.rs

crates/uv/src/commands/build.rs

zanieb · 2024-09-03T19:05:57Z

Another todo is to add documentation to

The publishing guide
The project concept

zanieb · 2024-09-03T19:06:50Z

How would that intersect with the ability to pass a single source dist file? Or the ability to pass a path to a directory?

I think if we're give a file target, we can just build that. If we're given a directory, we should treat that as the working directory for workspace / project discovery?

Related request at #1510 (comment) (not much more context there)

charliermarsh · 2024-09-03T23:41:39Z

I will add --outdir separately.

charliermarsh · 2024-09-04T00:24:54Z

Nevermind, I added --out-dir support here. I will do workspaces in another PR.

charliermarsh · 2024-09-04T01:33:53Z

Ok, I added docs in #6991, and workspace support (just --package for now) in #6990, so in theory the whole stack is ready to merge and ship once approved.

zanieb · 2024-09-04T14:29:45Z

crates/uv/src/commands/build.rs

+    }
+
+    // Initialize the registry client.
+    let client = RegistryClientBuilder::new(cache.clone())


Fyi there is a impl<'a> TryFrom<BaseClientBuilder<'a>> for RegistryClientBuilder<'a> so we can avoid some repetition here? Kind of annoying it creates a temporary cache though.

charliermarsh · 2024-09-04T15:23:44Z

Again PermissionError: [Errno 13] Permission denied: 'E:\/uv-tmp\/[TMP]/__init__.py'.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.4.4` -> `0.4.9` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.4.9`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#049) [Compare Source](astral-sh/uv@0.4.8...0.4.9) ##### Enhancements - Add support for managed Python 3.13 ([#7263](astral-sh/uv#7263)) - Upgrade managed CPython versions to latest patch releases ([#7263](astral-sh/uv#7263)) - Allow setting a target version for `uv self update` ([#7252](astral-sh/uv#7252)) - Create `py.typed` files during `uv init --lib` ([#7232](astral-sh/uv#7232)) - Add a dedicated error for packages that fail due to `distutils` deprecation ([#7239](astral-sh/uv#7239)) - Improve error message when requested Python version is unsupported ([#7269](astral-sh/uv#7269)) - Add `uv run --no-sync` ([#7192](\(https://github.com/astral-sh/uv/pull/7192\)) ##### Bug fixes - Avoid updating `pyproject.toml` offsets on non-add edits ([#7262](astral-sh/uv#7262)) - Invalidate cache when `--config-settings` change ([#7139](astral-sh/uv#7139)) - Remove workspace root for single-member workspace with `uv export` ([#7254](astral-sh/uv#7254)) ### [`v0.4.8`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#048) [Compare Source](astral-sh/uv@0.4.7...0.4.8) ##### Enhancements - Add support for dynamic cache keys ([#7136](astral-sh/uv#7136)) - Allow `.dist-info` names with dashes for post releases ([#7208](astral-sh/uv#7208)) - Use type hints in code from `uv init` ([#7225](astral-sh/uv#7225)) - Treat `.tgz` the same as `.tar.gz` ([#7201](astral-sh/uv#7201)) - Direct users towards `uv venv` to create a virtual environment ([#7188](astral-sh/uv#7188)) - Improve error message for uv init already init-ed ([#7198](astral-sh/uv#7198)) ##### Performance - Avoid batch prefetching for un-optimized registries ([#7226](astral-sh/uv#7226)) - Avoid iteration for singleton selections ([#7195](astral-sh/uv#7195)) ##### Bug fixes - Avoid extra newlines in debug logging for source builds ([#7174](astral-sh/uv#7174)) - Prune unreachable packages from `--universal` output ([#7209](astral-sh/uv#7209)) - Respect exclusion when collecting workspace members ([#7175](astral-sh/uv#7175)) - Use path file instead of `sitecustomize.py` ([#7161](astral-sh/uv#7161)) - Replace incorrect `--source` and `--binary` flags with correct `--sdist` and `--wheel` flags in `uv build` ([#7156](astral-sh/uv#7156)) ##### Documentation - Document support for `UV_INSTALL_DIR` ([#7107](astral-sh/uv#7107)) - List all supported sdist formats ([#7168](astral-sh/uv#7168)) ### [`v0.4.7`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#047) [Compare Source](astral-sh/uv@0.4.6...0.4.7) ##### Enhancements - Add `--no-emit-project` and friends to `uv export` ([#7110](astral-sh/uv#7110)) - Add `--output-file` to `uv export` ([#7109](astral-sh/uv#7109)) - Prune unused source distributions from the cache in `uv cache prune` ([#7112](astral-sh/uv#7112)) - Take intersection of constraint and requirements hashes ([#7108](astral-sh/uv#7108)) ##### Performance - Skip metadata fetch for `--no-deps` and `pip sync` ([#7127](astral-sh/uv#7127)) ##### Bug fixes - Avoid panicking when encountering an invalid Python version during `uv python list` ([#7131](astral-sh/uv#7131)) - Write trailing newline to `.python-version` files ([#7140](astral-sh/uv#7140)) ### [`v0.4.6`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#046) [Compare Source](astral-sh/uv@0.4.5...0.4.6) ##### Enhancements - Accept `--build-constraints` in `uv build` ([#7085](astral-sh/uv#7085)) - Add `--require-hashes` and `--verify-hashes` to `uv build` ([#7094](astral-sh/uv#7094)) - Add `--show-version-specifiers` to `uv tool list` ([#7050](astral-sh/uv#7050)) - Respect hashes in constraints files ([#7093](astral-sh/uv#7093)) - Upgrade installer scripts ([#7092](astral-sh/uv#7092)) - Allow specifying multiple packages in `uv tool upgrade` and `uninstall` ([#7037](astral-sh/uv#7037)) - Sort by implementation in `uv python list` ([#6918](astral-sh/uv#6918)) ##### Bug fixes - Invalidate lockfile when member versions change ([#7102](astral-sh/uv#7102)) - Strip fragments from direct source URLs in lockfile ([#7061](astral-sh/uv#7061)) - Support `--no-build` and `--no-binary` in `uv sync` et al ([#7100](astral-sh/uv#7100)) - Use distribution hash over registry hash ([#7060](astral-sh/uv#7060)) - Fix inverted log message ([#7063](astral-sh/uv#7063)) - Adjust Docker `ENTRYPOINT` and `CMD` for inherited images ([#7054](astral-sh/uv#7054)) ##### Documentation - Add winget to installers ([#7088](astral-sh/uv#7088)) - Document how to disable path modifications during install ([#7090](astral-sh/uv#7090)) - Document how to manually update locked package version ([#7083](astral-sh/uv#7083)) - Document official `setup-uv` action ([#7056](astral-sh/uv#7056)) - Update docs on `.python-version` file ([#7051](astral-sh/uv#7051)) ### [`v0.4.5`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#045) [Compare Source](astral-sh/uv@0.4.4...0.4.5) ##### Enhancements - Implement `uv build` ([#6895](astral-sh/uv#6895)) - Add `--package` support to `uv build` ([#6990](astral-sh/uv#6990)) - Prune unreachable packages from lockfile ([#6959](astral-sh/uv#6959)) - Prune unreachable wheels from lockfile ([#6961](astral-sh/uv#6961)) - Show build output by default in `uv build` ([#6912](astral-sh/uv#6912)) - Support `uv build --wheel` from source distributions ([#6898](astral-sh/uv#6898)) - Use the root project name for the project virtual environment prompt ([#7021](astral-sh/uv#7021)) ##### Bug fixes - Fix handling of inline optional dependencies in `uv add` ([#7023](astral-sh/uv#7023)) - Reflect exit code in `uv tool run` and `uv run` ([#6994](astral-sh/uv#6994)) - Revert `pyproject.toml` modifications on Ctrl-C ([#7024](astral-sh/uv#7024)) - Rollback `pyproject.toml` changes on all errors ([#7022](astral-sh/uv#7022)) - Use correct ordering semantics for narrowing upper-bounded Python requirements ([#7031](astral-sh/uv#7031)) - Fix segfault in Windows trampolines ([#6955](astral-sh/uv#6955)) - Remove unused `__future__.annotations` import in `_virtualenv.py` ([#6996](astral-sh/uv#6996)) ##### Documentation - Add documentation for `uv build` ([#6991](astral-sh/uv#6991)) - Add note to `extra` and `all-extras` in `uv sync` help ([#7013](astral-sh/uv#7013)) - Add project docs for `project.scripts` ([#7010](astral-sh/uv#7010)) - Fix available Docker image tag rendering and shorten list ([#7017](astral-sh/uv#7017)) - Touchup to the project environment config section ([#7038](astral-sh/uv#7038)) - Clarify precedence of `uv.toml` ([#6986](astral-sh/uv#6986)) - Fix available Docker tags for `-slim` variants ([#7041](astral-sh/uv#7041)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

charliermarsh added enhancement New feature or improvement to existing functionality cli Related to the command line interface labels Aug 31, 2024

charliermarsh force-pushed the charlie/build branch from 9db83ff to 2ed5720 Compare August 31, 2024 18:03

charliermarsh marked this pull request as ready for review August 31, 2024 18:04

charliermarsh force-pushed the charlie/build branch from 2ed5720 to f366ba7 Compare August 31, 2024 18:10

charliermarsh changed the base branch from main to charlie/sdist August 31, 2024 18:11

charliermarsh force-pushed the charlie/build branch 3 times, most recently from 24acf6a to 6933f30 Compare August 31, 2024 18:26

charliermarsh requested review from konstin and zanieb August 31, 2024 18:38

charliermarsh force-pushed the charlie/build branch from 6933f30 to e05c723 Compare August 31, 2024 18:39

phi-friday mentioned this pull request Sep 1, 2024

PEP621 적용 FinanceData/FinanceDataReader#228

Merged

4 tasks

konstin approved these changes Sep 2, 2024

View reviewed changes

charliermarsh force-pushed the charlie/sdist branch from f5d2f7c to dd6fb14 Compare September 2, 2024 18:08

Base automatically changed from charlie/sdist to main September 2, 2024 18:14

charliermarsh force-pushed the charlie/build branch 3 times, most recently from 76ad85a to 34fea79 Compare September 2, 2024 19:48

zanieb reviewed Sep 3, 2024

View reviewed changes

crates/uv-cli/src/lib.rs Outdated Show resolved Hide resolved

zanieb reviewed Sep 3, 2024

View reviewed changes

crates/uv-cli/src/lib.rs Outdated Show resolved Hide resolved

zanieb reviewed Sep 3, 2024

View reviewed changes

crates/uv/src/commands/build.rs Show resolved Hide resolved

zanieb reviewed Sep 3, 2024

View reviewed changes

crates/uv/src/commands/build.rs Outdated Show resolved Hide resolved

charliermarsh force-pushed the charlie/build branch 2 times, most recently from 8605599 to da3a201 Compare September 4, 2024 00:24

charliermarsh force-pushed the charlie/build branch from da3a201 to c2536ad Compare September 4, 2024 00:27

charliermarsh requested a review from zanieb September 4, 2024 13:24

charliermarsh force-pushed the charlie/build branch from c2536ad to 97bb372 Compare September 4, 2024 13:39

zanieb reviewed Sep 4, 2024

View reviewed changes

zanieb approved these changes Sep 4, 2024

View reviewed changes

Add uv build

b4702d1

charliermarsh force-pushed the charlie/build branch from 97bb372 to b4702d1 Compare September 4, 2024 15:13

charliermarsh enabled auto-merge (squash) September 4, 2024 15:13

charliermarsh disabled auto-merge September 4, 2024 15:23

charliermarsh merged commit df84d25 into main Sep 4, 2024

charliermarsh deleted the charlie/build branch September 4, 2024 15:23

zanieb mentioned this pull request Sep 4, 2024

Documentation on non-existent functionality (building distributions)? #7043

Closed

BrewTestBot mentioned this pull request Sep 4, 2024

uv 0.4.5 Homebrew/homebrew-core#183512

Merged

Comments

Conversation

charliermarsh commented Aug 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

charliermarsh commented Aug 31, 2024

Uh oh!

charliermarsh commented Sep 1, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

konstin Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

konstin Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

konstin commented Sep 2, 2024

Uh oh!

zanieb commented Sep 3, 2024

Uh oh!

charliermarsh commented Sep 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zanieb commented Sep 3, 2024

Uh oh!

zanieb commented Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

charliermarsh commented Sep 3, 2024

Uh oh!

charliermarsh commented Sep 4, 2024

Uh oh!

charliermarsh commented Sep 4, 2024

Uh oh!

zanieb Sep 4, 2024

Choose a reason for hiding this comment

Uh oh!

charliermarsh commented Sep 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

charliermarsh commented Aug 31, 2024 •

edited

Loading

zanieb commented Sep 3, 2024 •

edited

Loading