Merged
Conversation
konstin
added
enhancement
charliermarsh
approved these changes
Aug 29, 2024
Microsoft Store Python do not register themselves in the registry, so we port <https://github.com/python/cpython/blob/58ce131037ecb34d506a613f21993cde2056f628/PC/launcher2.c#L1744> and look them up on the file system in known locations. ## Test Plan Good question! So far I've confirmed that we find a store Python when I use `cargo run python list`, but we can't make this a part of any of the platform tests?
konstin
force-pushed
the
konsti/read-python-from-store
branch
from
24ee410 to
ffee09e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Store Pythons do not always register themselves in the registry, so we port https://github.com/python/cpython/blob/58ce131037ecb34d506a613f21993cde2056f628/PC/launcher2.c#L1744 and look them up on the filesystem in known locations.
Test Plan
So far I've confirmed that we find a store Python when I use
cargo run python list, can we make this a part of any of the platform tests maybe?