Skip to content

Comments

Add .exe suffix to tool command execution on Windows#6683

Open
zanieb wants to merge 2 commits intomainfrom
zb/use-exe-on-windowss
Open

Add .exe suffix to tool command execution on Windows#6683
zanieb wants to merge 2 commits intomainfrom
zb/use-exe-on-windowss

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Aug 27, 2024

Should close #6682

@zanieb zanieb added the bug Something isn't working label Aug 27, 2024
@zanieb zanieb force-pushed the zb/use-exe-on-windowss branch from 5ec4a29 to 77efce0 Compare August 27, 2024 12:11
@zanieb zanieb marked this pull request as draft August 27, 2024 12:11
@zanieb zanieb force-pushed the zb/use-exe-on-windowss branch 2 times, most recently from a9880ba to 550191c Compare August 27, 2024 12:37
@zanieb zanieb requested a review from charliermarsh August 27, 2024 12:58
@zanieb zanieb marked this pull request as ready for review August 27, 2024 12:58
@zanieb
Copy link
Member Author

zanieb commented Aug 27, 2024

Needs validation on Windows and more explicit test coverage.

@konstin tested this and I added a test with coverage

@samypr100
Copy link
Collaborator

This wouldn't solve gimme-aws-creds's case right? As there's no exe's in scripts declaration.

@zanieb
Copy link
Member Author

zanieb commented Aug 28, 2024

I presume not yeah.

@zanieb zanieb force-pushed the zb/use-exe-on-windowss branch 2 times, most recently from 0efdf7c to 40cddd3 Compare August 28, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build pyproject-build.exe not provided

2 participants