Skip to content

Comments

Rename uv sync --no-clean to uv sync --inexact#6241

Merged
zanieb merged 1 commit intorelease/3from
zb/no-clean-no-more
Aug 20, 2024
Merged

Rename uv sync --no-clean to uv sync --inexact#6241
zanieb merged 1 commit intorelease/3from
zb/no-clean-no-more

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Aug 20, 2024

No description provided.

@zanieb zanieb added cli Related to the command line interface preview Experimental behavior breaking A breaking change labels Aug 20, 2024
@zanieb zanieb requested a review from charliermarsh August 20, 2024 02:40
@zanieb
Copy link
Member Author

zanieb commented Aug 20, 2024

I'm not convinced that we shouldn't perform an exact sync by default, and while I like the --exact / --no-exact names — I don't feel that we should adjust the default behavior because it's easier to write the names of the flag.

I worry --no-exact is not obvious enough on its own.

@zanieb
Copy link
Member Author

zanieb commented Aug 20, 2024

(I don't love this name either, but it cannot remain --no-clean due to the conflict with cache clean semantics)

@zanieb
Copy link
Member Author

zanieb commented Aug 20, 2024

  • --no-prune
  • --retain
  • --preserve-extras (conflicts with the optional deps concept)
  • --preserve
  • --keep-unused
  • --skip-prune

@notatallshaw-gts
Copy link

notatallshaw-gts commented Aug 20, 2024

--no-remove
--no-delete (taken from rsync "delete" terminology)

@zanieb
Copy link
Member Author

zanieb commented Aug 20, 2024

But we will remove packages if they conflict with the requirements of the project.

@zanieb zanieb force-pushed the zb/no-clean-no-more branch from cf4180b to d30e52c Compare August 20, 2024 14:14
@charliermarsh
Copy link
Member

--ignore-unused? --skip-unused?

@zanieb
Copy link
Member Author

zanieb commented Aug 20, 2024

I worry a little about "unused" since they could be used just not declared.

@zanieb zanieb changed the title Rename uv sync --no-clean to uv sync --keep-untracked Rename uv sync --no-clean to uv sync --inexact Aug 20, 2024
@zanieb zanieb force-pushed the zb/no-clean-no-more branch from d30e52c to b19988d Compare August 20, 2024 15:48
@zanieb
Copy link
Member Author

zanieb commented Aug 20, 2024

Opting for --inexact with a --no-exact alias.

@zanieb zanieb force-pushed the zb/no-clean-no-more branch 2 times, most recently from cc2c37c to 4e59de4 Compare August 20, 2024 15:52
@zanieb zanieb force-pushed the zb/no-clean-no-more branch from 4e59de4 to 3fabb3c Compare August 20, 2024 15:52
@zanieb zanieb merged commit 7c69dd6 into release/3 Aug 20, 2024
@zanieb zanieb deleted the zb/no-clean-no-more branch August 20, 2024 16:01
zanieb added a commit that referenced this pull request Aug 20, 2024
zanieb added a commit that referenced this pull request Aug 20, 2024
zanieb added a commit that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking A breaking change cli Related to the command line interface preview Experimental behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants