Improve display of resolution errors for workspace member conflicts with optional dependencies#6123
Merged
Improve display of resolution errors for workspace member conflicts with optional dependencies#6123
Conversation
zanieb
added
error messages
zanieb
force-pushed
the
zb/optional-dep-err
branch
from
edb2de7 to
e765263
Compare
zanieb
changed the title
zanieb
force-pushed
the
zb/optional-dep-err
branch
from
e765263 to
3cd2eb7
Compare
zanieb
commented
Aug 15, 2024
This comment was marked as outdated.
This comment was marked as outdated.
zanieb
force-pushed
the
zb/optional-dep-err
branch
from
3cd2eb7 to
9e640fa
Compare
zanieb
force-pushed
the
zb/optional-dep-err
branch
from
9e640fa to
94d8020
Compare
charliermarsh
approved these changes
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have bad error messages for optional (extra) dependencies and development dependencies in workspaces:
:devand[extra]by accidentmember[extra]in tree processing collapse operation, so we'd include extra clauses like the ones we removed in Improve resolver error messages referencing workspace members #6092Also
package:devwhich was not showing:devfor some variants (see 94d8020)