Skip to content

Comments

Add env var to --link-mode=copy warning#6103

Merged
charliermarsh merged 1 commit intomainfrom
charlie/link-mode-env
Aug 15, 2024
Merged

Add env var to --link-mode=copy warning#6103
charliermarsh merged 1 commit intomainfrom
charlie/link-mode-env

Conversation

@charliermarsh
Copy link
Member

Summary

Closes #6101.

Test Plan

Screenshot 2024-08-14 at 9 35 45 PM

@charliermarsh charliermarsh added the error messages Messaging when something goes wrong label Aug 15, 2024
@charliermarsh charliermarsh requested a review from zanieb August 15, 2024 01:36
@charliermarsh charliermarsh marked this pull request as ready for review August 15, 2024 01:36
@stas00
Copy link

stas00 commented Aug 15, 2024

that looks good, Charlie - thank you for this improvement.

Attempt::UseCopyFallback => {
synchronized_copy(path, &out_path, locks)?;
warn_user_once!("Failed to hardlink files; falling back to full copy. This may lead to degraded performance. If this is intentional, use `--link-mode=copy` to suppress this warning.\n\nhint: If the cache and target directories are on different filesystems, hardlinking may not be supported.");
warn_user_once!("Failed to hardlink files; falling back to full copy. This may lead to degraded performance.\n If this is intentional, set `UV_LINK_MODE=copy` or use `--link-mode=copy` to suppress this warning.\n\nhint: If the cache and target directories are on different filesystems, hardlinking may not be supported.");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, need to update these to match the above format.

@charliermarsh charliermarsh force-pushed the charlie/link-mode-env branch from c2ff572 to b0a13ab Compare August 15, 2024 03:07
@charliermarsh charliermarsh enabled auto-merge (squash) August 15, 2024 03:09
@charliermarsh charliermarsh merged commit 7551097 into main Aug 15, 2024
@charliermarsh charliermarsh deleted the charlie/link-mode-env branch August 15, 2024 03:14
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 19, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.2.36` -> `0.2.37` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.2.37`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0237)

[Compare Source](astral-sh/uv@0.2.36...0.2.37)

##### Performance

-   Avoid cloning requirement for unchanged markers ([#&#8203;6116](astral-sh/uv#6116))

##### Bug fixes

-   Fix loading of cached metadata for Git distributions with subdirectories ([#&#8203;6094](astral-sh/uv#6094))

##### Error messages

-   Add env var to `--link-mode=copy` warning ([#&#8203;6103](astral-sh/uv#6103))
-   Avoid displaying "failed to download" on build failures for local source distributions ([#&#8203;6075](astral-sh/uv#6075))
-   Improve display of available package ranges ([#&#8203;6118](astral-sh/uv#6118))
-   Use "your requirements" consistently in resolver error messages ([#&#8203;6113](astral-sh/uv#6113))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

error messages Messaging when something goes wrong

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hardlinking warning -> how to silence it?

2 participants