Improve resolver error messages for single-project workspaces#6095
Merged
Improve resolver error messages for single-project workspaces#6095
Conversation
zanieb
force-pushed
the
zb/resolver-errors-projects
branch
from
faa52cc to
6bb296a
Compare
zanieb
commented
Aug 14, 2024
| /// workspaces, avoiding a level of indirection like "And because your project | ||
| /// requires your project, we can conclude that your projects's requirements are | ||
| /// unsatisfiable." | ||
| fn drop_root_dependency_on_project( |
Member
Author
There was a problem hiding this comment.
I initially thought I'd need to convert the dependency nodes from project -> other to root -> other but it seems like I can get away with not doing that! It depends on some behavior from #6092, otherwise we wouldn't display a proper conclusion but the message I added there about an unsatisfiable project suffices as a conclusion.
| ) { | ||
| match tree { | ||
| DerivationTree::External(_) => {} | ||
| DerivationTree::Derived(derived) => { |
Member
There was a problem hiding this comment.
I'm glad this pattern is working for us.
Member
Author
There was a problem hiding this comment.
Yeah, I'd previously had a hard time grokking PubGrub's collapse_no_versions so I thought this would be harder but it wasn't too bad and I think it could be a very powerful approach in the future.
charliermarsh
approved these changes
Aug 14, 2024
zanieb
force-pushed
the
zb/resolver-errors-workspaces
branch
2 times, most recently
from
c32128c to
b03445b
Compare
zanieb
force-pushed
the
zb/resolver-errors-projects
branch
from
6bb296a to
4d032bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends #6092 to improve resolver error messages for workspaces that have a single member.
As before, this requires a two-step approach of