Remove uses of Option<MarkerTree> in ResolutionGraph#6035
Merged
ibraheemdev merged 1 commit intomainfrom Aug 12, 2024
Merged
Conversation
ibraheemdev
force-pushed
the
ibraheem/option-marker-fix
branch
from
6b7d429 to
7ef3fb6
Compare
ibraheemdev
added
lock
ibraheemdev
commented
Aug 12, 2024
| { | ||
| if let (Some(marker), Some(ref version_marker)) = (edge.as_mut(), weight) { | ||
| marker.and(version_marker.clone()); | ||
| if edge.is_true() || weight.is_true() { |
Member
Author
There was a problem hiding this comment.
This feels a little odd..
Member
There was a problem hiding this comment.
You could also just OR them and simplify? But this seems simpler.
charliermarsh
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Missed this one in #5978.
Resolves #5902.