Skip to content

Comments

When installing a single Python version, do not display number installed#4939

Closed
zanieb wants to merge 1 commit intomainfrom
zb/install-message
Closed

When installing a single Python version, do not display number installed#4939
zanieb wants to merge 1 commit intomainfrom
zb/install-message

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Jul 9, 2024

e.g.,

Searching for Python versions matching: any Python
Installed Python 3.12.3 to: /Users/zb/Library/Application Support/uv/python/cpython-3.12.3-macos-aarch64-none
Installed Python in 1.80s

instead of Installed 1 version in 1.80s

@zanieb zanieb added cli Related to the command line interface preview Experimental behavior labels Jul 9, 2024
@T-256
Copy link
Contributor

T-256 commented Jul 9, 2024

 Searching for Python versions matching: any Python
-Installed Python 3.12.3 to: /Users/zb/Library/Application Support/uv/python/cpython-3.12.3-macos-aarch64-none
-Installed Python in 1.80s
+Installed `cpython-3.12.3-macos-aarch64-none` in 1.80s

Getting install location is available by uv python dir, so I think it's better to prevent leak username for privacy 🤷‍♂️

@zanieb
Copy link
Member Author

zanieb commented Jul 9, 2024

Could be nice to use the key there. Hm.

Idk about the install paths, we might need to consider that more holistically as part of #4896 as we do this all over the place right now.

@T-256
Copy link
Contributor

T-256 commented Jul 9, 2024

Installed 1 python version in 25ms
 + cpython-3.12.3-macos-aarch64-none

Also, I think it's worth to match it to output design of uv pip install which is more stabled.

@charliermarsh charliermarsh self-requested a review July 18, 2024 18:52
@charliermarsh charliermarsh self-assigned this Jul 18, 2024
@charliermarsh
Copy link
Member

Will take over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Related to the command line interface preview Experimental behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants