Conversation
Signed-off-by: William Woodruff <[email protected]>
woodruffw
commented
Feb 12, 2026
| .venv/bin/pip install ${PACKAGE_NAME} --no-index --find-links dist/ --force-reinstall | ||
| .venv/bin/${MODULE_NAME} --help | ||
| run: | | ||
| docker run --rm -v ${{ github.workspace }}:/io -w /io --env MODULE_NAME --env PACKAGE_NAME alpine:3.12 sh -c " |
Member
Author
There was a problem hiding this comment.
Noting: technically the double quote here means that ${MODULE_NAME} is getting expanded before it gets yeeted into the Docker container, but I don't think that matters for our purposes.
ntBre
added a commit
to astral-sh/ruff
that referenced
this pull request
Feb 12, 2026
Summary -- Copied from astral-sh/uv#17994 Test Plan -- Today's release
AlexWaygood
reviewed
Feb 12, 2026
ntBre
reviewed
Feb 12, 2026
Contributor
ntBre
left a comment
There was a problem hiding this comment.
I'll let someone from uv have the final approval, but this looks good to me. Thanks so much for jumping on this!
ntBre
added a commit
to astral-sh/ruff
that referenced
this pull request
Feb 12, 2026
Summary -- Copied from astral-sh/uv#17994 Test Plan -- Today's release and CI
konstin
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This action is incompatible within newer runner images, which come with Docker >= 29.
This doesn't affect uv yet because it's on an Ubuntu 22.04 runner for these steps, but we can preempt any future problems. See #17995 for that.
Test Plan
See what happens in CI.