Skip to content

Remove docker-run-action#17994

Merged
woodruffw merged 1 commit intomainfrom
ww/rm-docker-run-action
Feb 13, 2026
Merged

Remove docker-run-action#17994
woodruffw merged 1 commit intomainfrom
ww/rm-docker-run-action

Conversation

@woodruffw
Copy link
Member

@woodruffw woodruffw commented Feb 12, 2026

Summary

This action is incompatible within newer runner images, which come with Docker >= 29.

This doesn't affect uv yet because it's on an Ubuntu 22.04 runner for these steps, but we can preempt any future problems. See #17995 for that.

Test Plan

See what happens in CI.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw added the build:release Enable building release binaries for a pull request label Feb 12, 2026
.venv/bin/pip install ${PACKAGE_NAME} --no-index --find-links dist/ --force-reinstall
.venv/bin/${MODULE_NAME} --help
run: |
docker run --rm -v ${{ github.workspace }}:/io -w /io --env MODULE_NAME --env PACKAGE_NAME alpine:3.12 sh -c "
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting: technically the double quote here means that ${MODULE_NAME} is getting expanded before it gets yeeted into the Docker container, but I don't think that matters for our purposes.

ntBre added a commit to astral-sh/ruff that referenced this pull request Feb 12, 2026
Summary
--

Copied from astral-sh/uv#17994

Test Plan
--

Today's release
@woodruffw woodruffw self-assigned this Feb 12, 2026
@woodruffw woodruffw added the internal A refactor or improvement that is not user-facing label Feb 12, 2026
Copy link
Contributor

@ntBre ntBre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let someone from uv have the final approval, but this looks good to me. Thanks so much for jumping on this!

ntBre added a commit to astral-sh/ruff that referenced this pull request Feb 12, 2026
Summary
--

Copied from astral-sh/uv#17994

Test Plan
--

Today's release and CI
@woodruffw woodruffw merged commit 04b6d8f into main Feb 13, 2026
67 checks passed
@woodruffw woodruffw deleted the ww/rm-docker-run-action branch February 13, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build:release Enable building release binaries for a pull request internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants