Skip to content

Comments

Don't open lock files for writing#17956

Merged
EliteTK merged 1 commit intomainfrom
tk/open-lock-no-write
Feb 10, 2026
Merged

Don't open lock files for writing#17956
EliteTK merged 1 commit intomainfrom
tk/open-lock-no-write

Conversation

@EliteTK
Copy link
Contributor

@EliteTK EliteTK commented Feb 10, 2026

Summary

When opening lock files, don't open them for writing to avoid needing the write permission in the future.

Related: #17646

Test Plan

Test suite ran.

@EliteTK EliteTK added enhancement New feature or improvement to existing functionality test:macos Enable macOS tests for a pull request labels Feb 10, 2026
@EliteTK EliteTK force-pushed the tk/open-lock-no-write branch from 3b571e1 to d09b638 Compare February 10, 2026 15:47
@EliteTK EliteTK merged commit 75aadf2 into main Feb 10, 2026
95 of 97 checks passed
@EliteTK EliteTK deleted the tk/open-lock-no-write branch February 10, 2026 23:08
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Feb 17, 2026
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [uv](https://github.com/astral-sh/uv) | patch | `0.10.2` → `0.10.3` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (uv)</summary>

### [`v0.10.3`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0103)

[Compare Source](astral-sh/uv@0.10.2...0.10.3)

Released on 2026-02-16.

##### Python

- Add CPython 3.15.0a6

##### Enhancements

- Don't open file locks for writing ([#&#8203;17956](astral-sh/uv#17956))
- Make Windows trampoline error messages consistent with uv proper ([#&#8203;17969](astral-sh/uv#17969))
- Log which preview features are enabled ([#&#8203;17968](astral-sh/uv#17968))

##### Preview features

- Add support for ruff version constraints and `exclude-newer` in `uv format` ([#&#8203;17651](astral-sh/uv#17651))
- Fix script path handling when `target-workspace-discovery` is enabled ([#&#8203;17965](astral-sh/uv#17965))
- Use version constraints to select the default ruff version used by `uv format` ([#&#8203;17977](astral-sh/uv#17977))

##### Bug fixes

- Avoid matching managed Python versions by prefixes, e.g. don't match CPython 3.10 when `cpython-3.1` is specified ([#&#8203;17972](astral-sh/uv#17972))
- Fix handling of `--allow-existing` with minor version links on Windows ([#&#8203;17978](astral-sh/uv#17978))
- Fix panic when encountering unmanaged workspace members ([#&#8203;17974](astral-sh/uv#17974))
- Improve accuracy of request timing ([#&#8203;18007](astral-sh/uv#18007))
- Reject `u64::MAX` in version segments to prevent overflow ([#&#8203;17985](astral-sh/uv#17985))

##### Documentation

- Reference Debian Trixie instead of Bookworm ([#&#8203;17991](astral-sh/uv#17991))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNS4yIiwidXBkYXRlZEluVmVyIjoiNDMuMTUuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
EliteTK added a commit that referenced this pull request Feb 17, 2026
This reverts commit 75aadf2 (introduced
by #17956).

This fixes #18061.

On NFS `flock` implicitly falls back to `lockf` which requires the file
be open for writing when taking an exclusive lock.
zanieb pushed a commit that referenced this pull request Feb 17, 2026
This reverts commit 75aadf2 (introduced
by #17956).

This fixes #18061.

On NFS `flock` implicitly falls back to `lockf` which requires the file
be open for writing when taking an exclusive lock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or improvement to existing functionality test:macos Enable macOS tests for a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants