Retry timeout errors for streams #17735
Merged
zanieb merged 1 commit intokonsti/connect-timeout-and-retryfrom Feb 4, 2026
Merged
Retry timeout errors for streams #17735zanieb merged 1 commit intokonsti/connect-timeout-and-retryfrom
zanieb merged 1 commit intokonsti/connect-timeout-and-retryfrom
Conversation
konstin
added
enhancement
zanieb
reviewed
Jan 29, 2026
konstin
force-pushed
the
konsti/connect-timeout-and-retry
branch
from
ecb43c2 to
2ba2382
Compare
konstin
force-pushed
the
konsti/retry-timeouts
branch
from
cfe8280 to
64587fc
Compare
EliteTK
reviewed
Feb 3, 2026
Contributor
EliteTK
left a comment
EliteTK
left a comment
There was a problem hiding this comment.
It looks like only retry_read_timeout_stream fails if I remove the fix.
retry_read_timeout_index and connect_timeout_stream pass without the changes.
(Confirmed with @konstin via side channel that this doesn't seem intended so I'll postpone a full review until he checks this.)
| ├─▶ Request failed after 1 retry | ||
| ├─▶ Failed to read metadata: `http://[LOCALHOST]/tqdm-0.1-py3-none-any.whl` | ||
| ├─▶ Failed to read from zip file | ||
| ├─▶ an upstream reader returned an error: Failed to download distribution due to network timeout. Try increasing UV_HTTP_TIMEOUT (current value: [TIME]). |
Contributor
There was a problem hiding this comment.
Not something introduced by this PR but I noticed there is inconsistent casing on these errors.
Member
Author
There was a problem hiding this comment.
Looks like the an upstream reader returned an error is not from us, hence the different casing.
konstin
force-pushed
the
konsti/connect-timeout-and-retry
branch
from
2ba2382 to
1f1321d
Compare
konstin
force-pushed
the
konsti/retry-timeouts
branch
from
64587fc to
450b082
Compare
EliteTK
approved these changes
Feb 4, 2026
konstin
force-pushed
the
konsti/connect-timeout-and-retry
branch
2 times, most recently
from
c83593b to
31e94f6
Compare
konstin
force-pushed
the
konsti/retry-timeouts
branch
from
450b082 to
be26e10
Compare
zanieb
approved these changes
Feb 4, 2026
Member
|
Ah sorry I missed that this was stacked 😭 |
konstin
added a commit
that referenced
this pull request
Feb 5, 2026
Rebase of #17735 We're already retrying most timeout errors (only `retry_read_timeout_stream` didn't retry before), but not for streams after we already received some bytes which this PR adds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're already retrying most timeout errors (only
retry_read_timeout_streamdidn't retry before), but not for streams after we already received some bytes which this PR adds.