Skip to content

Fix scripts/check_system_python.py#17629

Merged
EliteTK merged 1 commit intomainfrom
tk/fix-ci-system-chocolatey
Jan 20, 2026
Merged

Fix scripts/check_system_python.py#17629
EliteTK merged 1 commit intomainfrom
tk/fix-ci-system-chocolatey

Conversation

@EliteTK
Copy link
Contributor

@EliteTK EliteTK commented Jan 20, 2026

Summary

Fix a bug in #17533 which was auto-merged despite failures.

Test Plan

N/A (CI PR).

@EliteTK EliteTK added bug Something isn't working internal A refactor or improvement that is not user-facing test:system Enable system tests for a pull request labels Jan 20, 2026
@EliteTK EliteTK force-pushed the tk/fix-ci-system-chocolatey branch from 6620af8 to 0eca255 Compare January 20, 2026 16:14
@EliteTK EliteTK enabled auto-merge (squash) January 20, 2026 16:21
@EliteTK EliteTK merged commit 6dd2c0c into main Jan 20, 2026
79 checks passed
@EliteTK EliteTK deleted the tk/fix-ci-system-chocolatey branch January 20, 2026 16:24
@zanieb
Copy link
Member

zanieb commented Jan 20, 2026

The system tests jobs aren't a part of the required checks

@EliteTK
Copy link
Contributor Author

EliteTK commented Jan 20, 2026

Yeah. I wasn't sure how exactly that worked. Now I've learned by way of a practical lesson.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working internal A refactor or improvement that is not user-facing test:system Enable system tests for a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants