Consolidate the disjoint target hints#17540
Merged
zanieb merged 2 commits intoastral-sh:mainfrom Jan 19, 2026
Merged
Conversation
Move the disjoint target hint logic from a separate method on NoSolutionError (hint_disjoint_targets) into the centralized generate_hints() method on PubGrubReportFormatter for consistency. Changes: - Add DisjointPythonVersion and DisjointEnvironment variants to PubGrubHint - Add current_environment parameter to generate_hints() - Move disjoint target check logic into generate_hints() - Remove hint_disjoint_targets method from NoSolutionError - Clean up unused imports in error.rs
The disjoint target hints now appear first in the hint list because they're generated at the start of generate_hints() instead of being added separately at the end.
Draft
konstin
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These should be generated alongside all the other resolver hints, I think.
The order changes here, but that seems fine.