Manually parse and reconcile Boolean environment variables by charliermarsh · Pull Request #17321 · astral-sh/uv

charliermarsh · 2026-01-05T00:22:05Z

Summary

This gives us more flexibility since we can avoid erroring on "conflicts" when one option is disabled (e.g., UV_FROZEN=0 uv lock --check).

Closes #13385.

Closes #13316.

konstin · 2026-01-05T12:47:09Z

This is a lot of churn in uv and moves us to a custom pattern of using clap that requires to manually call a check function. Would it be possible to fix this on the clap side (clap-rs/clap#5591), so we can stay with the regular clap pattern and get the validation at parse time?

charliermarsh · 2026-01-05T15:01:53Z

I will try here: clap-rs/clap#6211. If it ends up taking a long time, though, I'm gonna advocate for merging this since it's a big improvement.

Honestly... it's an improvement even if clap-rs/clap#6211 merges because we now track the source of these variables so we can report them in error messages. I might still advocate for this, it's so much better to be able to say UV_FROZEN is set than --frozen conflicts with whatever else.

zanieb · 2026-01-05T15:12:59Z

crates/uv-cli/src/options.rs

+    } else if matches!(parse_boolish_environment_variable(env_var), Ok(Some(true))) {
+        Flag::Enabled {
+            source: FlagSource::Env(env_var),
+            name,
+        }


I kind of wanted to move all the environment variable parsing into EnvironmentOptions

uv/crates/uv-settings/src/lib.rs

Line 590 in 13e7ad6

pub struct EnvironmentOptions {

then do combination with our three sources

uv/crates/uv/src/settings.rs

Lines 3453 to 3455 in 9949f08

args: PipOptions,

filesystem: Option<FilesystemOptions>,

environment: EnvironmentOptions,

I think this would fit into your pull request?

Let me see what I can do!

zanieb · 2026-01-05T15:16:41Z

It's a long-term goal (from my perspective) to disambiguate between environment variables and command-line arguments throughout, so I'm in favor of this kind of change.

charliermarsh · 2026-01-05T15:21:31Z

Per clap-rs/clap#5591 (comment), if this gets solved in Clap, it won't be until Clap v5.

crates/uv/tests/it/help.rs

The env var annotations are no longer auto-generated by Clap since we removed the `env =` attribute from the affected flags. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.9.22` → `0.9.24` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.9.24`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0924) [Compare Source](astral-sh/uv@0.9.23...0.9.24) Released on 2026-01-09. ##### Bug fixes - Fix handling of `UV_NO_SYNC=1 uv run ...` ([#17391](astral-sh/uv#17391)) - Rebuild dynamic distribution when version changes with `--no-cache` ([#17387](astral-sh/uv#17387)) ##### Documentation - Add Rust language classifier ([#17389](astral-sh/uv#17389)) ### [`v0.9.23`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0923) [Compare Source](astral-sh/uv@0.9.22...0.9.23) Released on 2026-01-09. ##### Enhancements - Only write portable paths in `RECORD` files ([#17339](astral-sh/uv#17339)) - Support relative paths in `UV_PYTHON_BIN_DIR` and `UV_TOOL_BIN_DIR` ([#17367](astral-sh/uv#17367)) ##### Preview features - Enable uploads to S3 via pre-signed URLs ([#17349](astral-sh/uv#17349)) ##### Configuration - Allow setting proxy variables via global / user configuration ([#16918](astral-sh/uv#16918)) - Manually parse and reconcile Boolean environment variables ([#17321](astral-sh/uv#17321)) ##### Bug fixes - Avoid broken build artifacts on build failure ([#17276](astral-sh/uv#17276)) - Fix missing dependencies on synthetic root in SBOM export ([#17363](astral-sh/uv#17363)) - Recognize `armv8l` as an alias for `armv7l` in platform tag parsing ([#17384](astral-sh/uv#17384)) - Fix redaction of a URL in a middleware trace log ([#17346](astral-sh/uv#17346)) ##### Documentation - Add `index.md` suggestion to `llms.txt` ([#17362](astral-sh/uv#17362)) - Clarify that `uv run` uses inexact syncing by default ([#17366](astral-sh/uv#17366)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

charliermarsh added bug Something isn't working configuration Settings and such labels Jan 5, 2026

charliermarsh temporarily deployed to uv-test-registries January 5, 2026 00:23 — with GitHub Actions Inactive

charliermarsh force-pushed the charlie/err-from-env branch from 766f09c to 5affc21 Compare January 5, 2026 00:34

charliermarsh temporarily deployed to uv-test-registries January 5, 2026 00:36 — with GitHub Actions Inactive

charliermarsh force-pushed the charlie/err-from-env branch from 5affc21 to 7474e50 Compare January 5, 2026 00:56

charliermarsh temporarily deployed to uv-test-registries January 5, 2026 00:59 — with GitHub Actions Inactive

charliermarsh force-pushed the charlie/err-from-env branch from 7474e50 to b623ef3 Compare January 5, 2026 01:00

charliermarsh temporarily deployed to uv-test-registries January 5, 2026 01:02 — with GitHub Actions Inactive

charliermarsh marked this pull request as ready for review January 5, 2026 01:07

charliermarsh temporarily deployed to uv-test-registries January 5, 2026 01:11 — with GitHub Actions Inactive

Base automatically changed from charlie/err-msg to main January 5, 2026 12:40

zanieb reviewed Jan 5, 2026

View reviewed changes

charliermarsh force-pushed the charlie/err-from-env branch from bd84e8b to 08a1b49 Compare January 5, 2026 15:37

charliermarsh requested review from konstin and zanieb January 5, 2026 15:37

charliermarsh temporarily deployed to uv-test-registries January 5, 2026 15:39 — with GitHub Actions Inactive

charliermarsh commented Jan 6, 2026

View reviewed changes

crates/uv/tests/it/help.rs Show resolved Hide resolved

zanieb approved these changes Jan 6, 2026

View reviewed changes

charliermarsh and others added 3 commits January 6, 2026 12:46

Read from env

bd5579f

Use EnvironmentOptions

4642228

charliermarsh force-pushed the charlie/err-from-env branch from 08a1b49 to 4642228 Compare January 6, 2026 17:47

charliermarsh temporarily deployed to uv-test-registries January 6, 2026 17:49 — with GitHub Actions Inactive

charliermarsh temporarily deployed to uv-test-registries January 6, 2026 18:05 — with GitHub Actions Inactive

Re-add annotations

8328576

charliermarsh force-pushed the charlie/err-from-env branch from e6c8e74 to 8328576 Compare January 6, 2026 18:07

charliermarsh temporarily deployed to uv-test-registries January 6, 2026 18:09 — with GitHub Actions Inactive

charliermarsh temporarily deployed to uv-test-registries January 6, 2026 20:25 — with GitHub Actions Inactive

Retain long help

fd77b98

charliermarsh force-pushed the charlie/err-from-env branch from 546b093 to fd77b98 Compare January 6, 2026 20:29

charliermarsh temporarily deployed to uv-test-registries January 6, 2026 20:31 — with GitHub Actions Inactive

charliermarsh enabled auto-merge (squash) January 6, 2026 20:39

charliermarsh merged commit cd55d1c into main Jan 6, 2026
101 checks passed

charliermarsh deleted the charlie/err-from-env branch January 6, 2026 20:43

BrewTestBot mentioned this pull request Jan 9, 2026

uv 0.9.23 Homebrew/homebrew-core#262077

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Manually parse and reconcile Boolean environment variables#17321

Manually parse and reconcile Boolean environment variables#17321
charliermarsh merged 5 commits intomainfrom
charlie/err-from-env

charliermarsh commented Jan 5, 2026 •

edited

Loading

Uh oh!

konstin commented Jan 5, 2026

Uh oh!

charliermarsh commented Jan 5, 2026

Uh oh!

zanieb Jan 5, 2026

Uh oh!

zanieb Jan 5, 2026

Uh oh!

charliermarsh Jan 5, 2026

Uh oh!

zanieb commented Jan 5, 2026

Uh oh!

charliermarsh commented Jan 5, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	args: PipOptions,
	filesystem: Option<FilesystemOptions>,
	environment: EnvironmentOptions,

Comments

Conversation

charliermarsh commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

konstin commented Jan 5, 2026

Uh oh!

charliermarsh commented Jan 5, 2026

Uh oh!

zanieb Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

zanieb Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

charliermarsh Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

zanieb commented Jan 5, 2026

Uh oh!

charliermarsh commented Jan 5, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

charliermarsh commented Jan 5, 2026 •

edited

Loading