Fix dropped support of - in pip constraints/overrides/excludes/build_constraints#17188
Merged
charliermarsh merged 3 commits intoastral-sh:mainfrom Dec 24, 2025
Merged
Conversation
Since astral-sh#16923, `-` stdin paths are only supported on the `RequirementsSource::Extensionless`. However, parsing of cli arguments using `from_requirements_txt`, `from_constraints_txt` `from_overrides_txt` would always output a `RequirementsSource::RequirementsTxt`. I've added a small check in those for the `-` paths to use `ExtensionLess`. I'm not too sure about this change, as it would also implicitly start allowing PEP 723 scripts as input to overrides/constraints. I don't see the direct issue in that, but then maybe we should explicitly handle it so that an `--overrides=script.py` would also be supported.
Member
|
Can you add some test coverage for this? |
charliermarsh
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #16923,
-stdin paths are suddenly only supported on theRequirementsSource::Extensionless. However, parsing of cli arguments usingfrom_requirements_txt,from_constraints_txtfrom_overrides_txtwould always output aRequirementsSource::RequirementsTxt. Resulting in the error:In this PR, I've added a small check in those for the
-paths to useRequirementsSource::ExtensionLess.I'm not too sure about this change though, as it would also implicitly start allowing PEP 723 scripts as input to overrides/constraints. I don't see the direct issue in that, but then maybe we should explicitly handle it so that an
--overrides=script.pywould also be supported. @zanieb what do you think?Relates to #17227