Skip to content

Comments

Make pyx credential error message reflect the realm#17152

Open
zsol wants to merge 2 commits intomainfrom
zsol/jj-zmwropzqtzxm
Open

Make pyx credential error message reflect the realm#17152
zsol wants to merge 2 commits intomainfrom
zsol/jj-zmwropzqtzxm

Conversation

@zsol
Copy link
Member

@zsol zsol commented Dec 16, 2025

This is unlikely to affect people who aren't pyx devs.

Test Plan

PYX_API_URL=http://localhost:8000 uv pip install --default-index $PYX_API_URL/simple foo yields

Run `PYX_API_URL='http://localhost:8000' uv auth login http://localhost:8000` to authenticate uv with pyx

But the error message against production pyx.dev remains the same.

@charliermarsh
Copy link
Member

Should we include PYX_API_URL in the error message?

@zsol zsol temporarily deployed to uv-test-registries December 16, 2025 19:28 — with GitHub Actions Inactive
zsol added 2 commits January 12, 2026 10:04
For example:
```
Run `uv auth login http://localhost:8000` to authenticate uv with pyx
```
While keeping `pyx.dev` for the common case.
@zsol zsol force-pushed the zsol/jj-zmwropzqtzxm branch from 4149131 to fdd14aa Compare January 12, 2026 10:14
@zsol zsol marked this pull request as ready for review January 12, 2026 10:15
@zsol zsol requested review from charliermarsh and zanieb January 12, 2026 10:15
@zsol zsol temporarily deployed to uv-test-registries January 12, 2026 10:17 — with GitHub Actions Inactive
@konstin
Copy link
Member

konstin commented Jan 12, 2026

The env var syntax doesn't work on Windows, can we use a CLI parameter instead?

@konstin konstin added enhancement New feature or improvement to existing functionality error messages Messaging when something goes wrong labels Jan 12, 2026
@zsol
Copy link
Member Author

zsol commented Jan 12, 2026

The env var syntax doesn't work on Windows, can we use a CLI parameter instead?

I don't think there's a CLI parameter for this unfortunately. If you'd like, I can add OS-specific error messages (with the understanding that the message will be less helpful than it could be on Windows+cygwin or git bash)

zanieb added a commit that referenced this pull request Feb 4, 2026
…API_URL` differing (#17856)

Inspired by the blocking discussion at
#17152

It seems like a bad user experience for the login invocation to pyx to
be affected by changing the API URL. We should just recognize that they
are attempting to use pyx.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or improvement to existing functionality error messages Messaging when something goes wrong

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants