Skip to content

Comments

Better rendering for multiline error messages#17132

Merged
konstin merged 3 commits intomainfrom
konsti/multiline-errors
Dec 15, 2025
Merged

Better rendering for multiline error messages#17132
konstin merged 3 commits intomainfrom
konsti/multiline-errors

Conversation

@konstin
Copy link
Member

@konstin konstin commented Dec 15, 2025

Split out from #17110

Indent multiline error messages properly, and add a test with a multiline context and a context below since that combination isn't captured atm.

Split out from #17110

Indent multiline error messages properly, and add test since it wasn't captured previously.
@konstin konstin requested a review from zanieb December 15, 2025 13:06
@konstin konstin added the enhancement New feature or improvement to existing functionality label Dec 15, 2025
@zanieb zanieb had a problem deploying to uv-test-registries December 15, 2025 14:25 — with GitHub Actions Failure
@zanieb zanieb temporarily deployed to uv-test-registries December 15, 2025 15:15 — with GitHub Actions Inactive
Caused by: Failed to fetch https://example.com/upload/python3.13.tar.zst
Server says: This endpoint only support POST requests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of IDEs are configured to strip trailing whitespace, which will strip this. Could we instead avoid indenting empty lines? This would be more consistent with ruff and rustfmt, which both don't indent empty lines.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's fine with me too.

@konstin konstin enabled auto-merge (squash) December 15, 2025 15:46
@konstin konstin temporarily deployed to uv-test-registries December 15, 2025 15:49 — with GitHub Actions Inactive
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 15, 2025

CodSpeed Performance Report

Merging #17132 will not alter performance

Comparing konsti/multiline-errors (cdfe1cd) with main (a768a9d)

Summary

✅ 5 untouched

@zanieb zanieb force-pushed the konsti/multiline-errors branch from 03e915a to cdfe1cd Compare December 15, 2025 16:14
@zanieb zanieb temporarily deployed to uv-test-registries December 15, 2025 16:17 — with GitHub Actions Inactive
@konstin konstin merged commit a5d50a2 into main Dec 15, 2025
121 of 122 checks passed
@konstin konstin deleted the konsti/multiline-errors branch December 15, 2025 16:29
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 15, 2025

Unable to generate the flame graphs

The performance report has correctly been generated, but there was an internal error while generating the flame graphs for this run. We're working on fixing the issue. Feel free to contact us on Discord or at [email protected] if the issue persists.

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Dec 18, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.9.17` -> `0.9.18` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.9.18`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0918)

[Compare Source](astral-sh/uv@0.9.17...0.9.18)

Released on 2025-12-16.

##### Enhancements

- Add value hints to command line arguments to improve shell completion accuracy ([#&#8203;17080](astral-sh/uv#17080))
- Improve error handling in `uv publish` ([#&#8203;17096](astral-sh/uv#17096))
- Improve rendering of multiline error messages ([#&#8203;17132](astral-sh/uv#17132))
- Support redirects in `uv publish` ([#&#8203;17130](astral-sh/uv#17130))
- Include Docker images with the alpine version, e.g., `python3.x-alpine3.23` ([#&#8203;17100](astral-sh/uv#17100))

##### Configuration

- Accept `--torch-backend` in `[tool.uv]` ([#&#8203;17116](astral-sh/uv#17116))

##### Performance

- Speed up `uv cache size` ([#&#8203;17015](astral-sh/uv#17015))
- Initialize S3 signer once ([#&#8203;17092](astral-sh/uv#17092))

##### Bug fixes

- Avoid panics due to reads on failed requests ([#&#8203;17098](astral-sh/uv#17098))
- Enforce latest-version in `@latest` requests ([#&#8203;17114](astral-sh/uv#17114))
- Explicitly set `EntryType` for file entries in tar ([#&#8203;17043](astral-sh/uv#17043))
- Ignore `pyproject.toml` index username in lockfile comparison ([#&#8203;16995](astral-sh/uv#16995))
- Relax error when using `uv add` with `UV_GIT_LFS` set ([#&#8203;17127](astral-sh/uv#17127))
- Support file locks on ExFAT on macOS ([#&#8203;17115](astral-sh/uv#17115))
- Change schema for `exclude-newer` into optional string ([#&#8203;17121](astral-sh/uv#17121))

##### Documentation

- Drop arm musl caveat from Docker documentation ([#&#8203;17111](astral-sh/uv#17111))
- Fix version reference in resolver example ([#&#8203;17085](astral-sh/uv#17085))
- Better documentation for `exclude-newer*` ([#&#8203;17079](astral-sh/uv#17079))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi41Ny4xIiwidXBkYXRlZEluVmVyIjoiNDIuNTcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or improvement to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants