Skip to content

Comments

Relax error when using uv add with UV_GIT_LFS set#17127

Merged
zanieb merged 1 commit intoastral-sh:mainfrom
samypr100:track-lfs-arg-vs-env
Dec 15, 2025
Merged

Relax error when using uv add with UV_GIT_LFS set#17127
zanieb merged 1 commit intoastral-sh:mainfrom
samypr100:track-lfs-arg-vs-env

Conversation

@samypr100
Copy link
Collaborator

@samypr100 samypr100 commented Dec 13, 2025

Summary

Closes #17083

Previously having UV_GIT_LFS set would cause an error when adding a non-git requirement such as error: `requirement` did not resolve to a Git repository, but a Git extension (`--lfs`) was provided.

Test Plan

Additional test has been added.

@samypr100 samypr100 force-pushed the track-lfs-arg-vs-env branch 3 times, most recently from 1cdf7ac to ad55619 Compare December 13, 2025 19:46
@samypr100 samypr100 marked this pull request as ready for review December 13, 2025 19:46
@samypr100 samypr100 marked this pull request as draft December 13, 2025 20:17
@samypr100 samypr100 force-pushed the track-lfs-arg-vs-env branch 2 times, most recently from f47d08d to 5b023cc Compare December 13, 2025 21:25
@samypr100 samypr100 marked this pull request as ready for review December 13, 2025 22:32
@samypr100 samypr100 force-pushed the track-lfs-arg-vs-env branch from 5b023cc to 8abff32 Compare December 14, 2025 22:52
@samypr100 samypr100 changed the title Differentiate between --lfs and UV_GIT_LFS Relax error when using uv add with UV_GIT_LFS set Dec 14, 2025
@zanieb zanieb merged commit a768a9d into astral-sh:main Dec 15, 2025
102 checks passed
@zanieb zanieb added the bug Something isn't working label Dec 15, 2025
@samypr100 samypr100 deleted the track-lfs-arg-vs-env branch December 15, 2025 20:58
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Dec 18, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.9.17` -> `0.9.18` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.9.18`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0918)

[Compare Source](astral-sh/uv@0.9.17...0.9.18)

Released on 2025-12-16.

##### Enhancements

- Add value hints to command line arguments to improve shell completion accuracy ([#&#8203;17080](astral-sh/uv#17080))
- Improve error handling in `uv publish` ([#&#8203;17096](astral-sh/uv#17096))
- Improve rendering of multiline error messages ([#&#8203;17132](astral-sh/uv#17132))
- Support redirects in `uv publish` ([#&#8203;17130](astral-sh/uv#17130))
- Include Docker images with the alpine version, e.g., `python3.x-alpine3.23` ([#&#8203;17100](astral-sh/uv#17100))

##### Configuration

- Accept `--torch-backend` in `[tool.uv]` ([#&#8203;17116](astral-sh/uv#17116))

##### Performance

- Speed up `uv cache size` ([#&#8203;17015](astral-sh/uv#17015))
- Initialize S3 signer once ([#&#8203;17092](astral-sh/uv#17092))

##### Bug fixes

- Avoid panics due to reads on failed requests ([#&#8203;17098](astral-sh/uv#17098))
- Enforce latest-version in `@latest` requests ([#&#8203;17114](astral-sh/uv#17114))
- Explicitly set `EntryType` for file entries in tar ([#&#8203;17043](astral-sh/uv#17043))
- Ignore `pyproject.toml` index username in lockfile comparison ([#&#8203;16995](astral-sh/uv#16995))
- Relax error when using `uv add` with `UV_GIT_LFS` set ([#&#8203;17127](astral-sh/uv#17127))
- Support file locks on ExFAT on macOS ([#&#8203;17115](astral-sh/uv#17115))
- Change schema for `exclude-newer` into optional string ([#&#8203;17121](astral-sh/uv#17121))

##### Documentation

- Drop arm musl caveat from Docker documentation ([#&#8203;17111](astral-sh/uv#17111))
- Fix version reference in resolver example ([#&#8203;17085](astral-sh/uv#17085))
- Better documentation for `exclude-newer*` ([#&#8203;17079](astral-sh/uv#17079))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi41Ny4xIiwidXBkYXRlZEluVmVyIjoiNDIuNTcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uv add fails if UV_GIT_LFS=1

2 participants