Draft
Conversation
af516f2 to
8ef0c55
Compare
8ef0c55 to
633cf84
Compare
konstin
added a commit
that referenced
this pull request
Dec 15, 2025
Split out from #17110 Indent multiline error messages properly, and add test since it wasn't captured previously.
konstin
added a commit
that referenced
this pull request
Dec 15, 2025
Split out from #17110 Indent multiline error messages properly, and add a test with a multiline context and a context below since that combination isn't captured atm. --------- Co-authored-by: Zanie Blue <[email protected]>
16f450d to
4e56519
Compare
53e8893 to
73b9b0c
Compare
fe700e0 to
9f11141
Compare
9f11141 to
3932c28
Compare
3932c28 to
66db1a1
Compare
zanieb
commented
Jan 17, 2026
| /// This performs tree transformation once and returns both the formatted | ||
| /// error report and hints. The hints should be displayed separately from | ||
| /// the main error message to avoid indentation issues. | ||
| pub fn report_and_hints(&self) -> (String, IndexSet<PubGrubHint>) { |
Member
Author
There was a problem hiding this comment.
This seems wrong. Will investigate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.