Skip to content

Comments

Remove miette#17110

Draft
zanieb wants to merge 2 commits intomainfrom
zb/miette-remove-ii
Draft

Remove miette#17110
zanieb wants to merge 2 commits intomainfrom
zb/miette-remove-ii

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented Dec 12, 2025

No description provided.

@zanieb zanieb temporarily deployed to uv-test-registries December 12, 2025 19:12 — with GitHub Actions Inactive
@zanieb zanieb force-pushed the zb/miette-remove-ii branch from af516f2 to 8ef0c55 Compare December 12, 2025 19:26
@zanieb zanieb temporarily deployed to uv-test-registries December 12, 2025 19:28 — with GitHub Actions Inactive
@zanieb zanieb force-pushed the zb/miette-remove-ii branch from 8ef0c55 to 633cf84 Compare December 12, 2025 19:42
@zanieb zanieb temporarily deployed to uv-test-registries December 12, 2025 19:45 — with GitHub Actions Inactive
@zanieb zanieb added the no-build Disable building binaries in CI label Dec 12, 2025
konstin added a commit that referenced this pull request Dec 15, 2025
Split out from #17110

Indent multiline error messages properly, and add test since it wasn't captured previously.
konstin added a commit that referenced this pull request Dec 15, 2025
Split out from #17110

Indent multiline error messages properly, and add a test with a
multiline context and a context below since that combination isn't
captured atm.

---------

Co-authored-by: Zanie Blue <[email protected]>
@zanieb zanieb force-pushed the zb/miette-remove-ii branch 2 times, most recently from 16f450d to 4e56519 Compare January 16, 2026 16:53
@zanieb zanieb mentioned this pull request Jan 16, 2026
1 task
@zanieb zanieb force-pushed the zb/miette-remove-ii branch 3 times, most recently from 53e8893 to 73b9b0c Compare January 16, 2026 18:16
@zanieb zanieb force-pushed the zb/miette-remove-ii branch 4 times, most recently from fe700e0 to 9f11141 Compare January 16, 2026 21:34
@zanieb zanieb force-pushed the zb/miette-remove-ii branch from 9f11141 to 3932c28 Compare January 17, 2026 16:53
@zanieb zanieb force-pushed the zb/miette-remove-ii branch from 3932c28 to 66db1a1 Compare January 17, 2026 17:23
/// This performs tree transformation once and returns both the formatted
/// error report and hints. The hints should be displayed separately from
/// the main error message to avoid indentation issues.
pub fn report_and_hints(&self) -> (String, IndexSet<PubGrubHint>) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong. Will investigate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to #17540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-build Disable building binaries in CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant