Disable always-authenticate when running under Dependabot#16773
Merged
Conversation
zanieb
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
zanieb
changed the title
DEPENDABOT
zanieb
force-pushed
the
zb/authenticate
branch
from
35c06c4 to
77db992
Compare
zanieb
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
woodruffw
approved these changes
Nov 18, 2025
Member
woodruffw
left a comment
woodruffw
left a comment
There was a problem hiding this comment.
Distressing, but makes sense.
| // Dependabot intercepts HTTP requests and injects credentials, which means that we | ||
| // cannot eagerly enforce an `AuthPolicy` as we don't know whether credentials will be | ||
| // added outside of uv. | ||
| && !std::env::var(EnvVars::DEPENDABOT).is_ok_and(|value| value == "true")); |
Member
There was a problem hiding this comment.
Should we avoid doing re-reading this in this hot path?
Member
Author
There was a problem hiding this comment.
Uh we could. I assumed it was very cheap. I guess we're validating that the value is utf-8 and allocating a string?
I'm a little wary of the indirection of moving it out, I'm not sure where I'd put it.
Member
There was a problem hiding this comment.
Yeah, environment accesses are somewhat expensive in Rust, since Rust acquires a lock on the entire environment (at least on macOS/Linux) for individual variable accesses. That wouldn't matter much in a lot of workloads, but I can imagine we'd have environment read contention in our setting because of work-splitting across multiple tokio-managed threads.
(It's probably still not a ton, but a OnceCell or LazyLock would avoid it as a concern.)
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 21, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.9.10` -> `0.9.11` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.9.11`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0911) [Compare Source](astral-sh/uv@0.9.10...0.9.11) Released on 2025-11-20. ##### Python - Add CPython 3.15.0a2 See the [`python-build-standalone` release notes](https://github.com/astral-sh/python-build-standalone/releases/tag/20251120) for details. ##### Enhancements - Add SBOM support to `uv export` ([#​16523](astral-sh/uv#16523)) - Publish to `crates.io` ([#​16770](astral-sh/uv#16770)) ##### Preview features - Add `uv workspace list --paths` ([#​16776](astral-sh/uv#16776)) - Fix the preview warning on `uv workspace dir` ([#​16775](astral-sh/uv#16775)) ##### Bug fixes - Fix `uv init` author serialization via `toml_edit` inline tables ([#​16778](astral-sh/uv#16778)) - Fix status messages without TTY ([#​16785](astral-sh/uv#16785)) - Preserve end-of-line comment whitespace when editing `pyproject.toml` ([#​16734](astral-sh/uv#16734)) - Disable `always-authenticate` when running under Dependabot ([#​16773](astral-sh/uv#16773)) ##### Documentation - Document the new behavior for free-threaded python versions ([#​16781](astral-sh/uv#16781)) - Improve note about build system in publish guide ([#​16788](astral-sh/uv#16788)) - Move do not upload publish note out of the guide into concepts ([#​16789](astral-sh/uv#16789)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNzMuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE3My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot appears to run a proxy which intercepts all requests and adds credentials — credentials are not provided via the CLI or environment variables and there's no way for a user to do so. This means that when
authenticate = "always"is used (or when the index URL is on a pyx domain), uv will fail even though Dependabot may intercept the request and add credentials.See https://github.com/dependabot/dependabot-core/#private-registry-credential-management