Fix handling of `python install --default` for pre-release Python versions by nooscraft · Pull Request #16706 · astral-sh/uv

nooscraft · 2025-11-12T14:56:44Z

Summary

Fixes --default not creating default executable links for pre-release Python versions.

When using --default with a pre-release version like 3.15.0a1, the code was checking matches_installation() against the download request instead of the original user request. This caused the check to fail since the download request doesn't match pre-release versions the same way.

Changed it to use installation.satisfies(&first_request.request) when --default is used, which checks against the original user request.

Fixes #16696

Test Plan

Added python_install_default_prerelease test that installs Python 3.15 with --default and verifies all three executable links (python3.15, python3, python) are created. The test skips gracefully if 3.15 isn't available.

All existing tests pass.

Use installation.satisfies() instead of matches_installation() when --default is used, allowing pre-release versions like 3.15.0a1 to be set as default when requested.

crates/uv/src/commands/python/install.rs

When --default is used, only one request is allowed, so we can skip the installation matching check since all installations in the loop already match the request.

zanieb · 2025-11-12T17:54:40Z

Sorry another question here... isn't the entire first_request matching meaningless then? Can we just remove that.. ?

When is_default_install is true, there's only one request and all installations in the loop already match that request, so the check is redundant.

nooscraft · 2025-11-12T18:07:21Z

Sorry another question here... isn't the entire first_request matching meaningless then? Can we just remove that.. ?

Yes, When is_default_install is true, there's only one request and all installations in the loop already match it, so the check was redundant.
I've removed the first_request.matches_installation(installation) check and the unused first_request variable. The code now just checks default || (is_default_install && preview.is_enabled(...)).

zanieb · 2025-11-12T18:11:38Z

crates/uv/tests/it/python_install.rs

+    // Try to install Python 3.15, which currently only exists as a pre-release (3.15.0a1).
+    // If 3.15 is not available, this test will be skipped naturally.
+    let Ok(output) = context
+        .python_install()
+        .arg("--default")
+        .arg("--preview-features")
+        .arg("python-install-default")
+        .arg("3.15")
+        .output()
+    else {
+        return; // Skip test if command fails
+    };


We should .assert().success() here instead. 3.15 is available, we shouldn't let the test silently fail.

Yup, fixed this!

zanieb · 2025-11-12T18:11:49Z

crates/uv/tests/it/python_install.rs

+    // Clean up
+    let _ = context.python_uninstall().arg("--all").output();


We don't need this, the tests run in isolated contexts

zanieb · 2025-11-12T18:12:11Z

crates/uv/tests/it/python_install.rs

+    // Test that --default works with pre-release versions (e.g., 3.15.0a1).
+    // This test verifies the fix for issue #16696 where --default didn't create
+    // python.exe and python3.exe links for pre-release versions.


This belongs in a doc comment /// above the function

Moved to doc comment

Use assert().success() to ensure the command succeeds instead of silently skipping. Remove cleanup since tests run in isolated contexts.

zanieb · 2025-11-12T18:33:52Z

Thanks!

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.9.9` -> `0.9.10` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.9.10`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0910) [Compare Source](astral-sh/uv@0.9.9...0.9.10) Released on 2025-11-17. ##### Enhancements - Add support for `SSL_CERT_DIR` ([#16473](astral-sh/uv#16473)) - Enforce UTF‑8-encoded license files during `uv build` ([#16699](astral-sh/uv#16699)) - Error when a `project.license-files` glob matches nothing ([#16697](astral-sh/uv#16697)) - `pip install --target` (and `sync`) install Python if necessary ([#16694](astral-sh/uv#16694)) - Account for `python_downloads_json_url` in pre-release Python version warnings ([#16737](astral-sh/uv#16737)) - Support HTTP/HTTPS URLs in `uv python --python-downloads-json-url` ([#16542](astral-sh/uv#16542)) ##### Preview features - Add support for `--upgrade` in `uv python install` ([#16676](astral-sh/uv#16676)) - Fix handling of `python install --default` for pre-release Python versions ([#16706](astral-sh/uv#16706)) - Add `uv workspace list` to list workspace members ([#16691](astral-sh/uv#16691)) ##### Bug fixes - Don't check file URLs for ambiguously parsed credentials ([#16759](astral-sh/uv#16759)) ##### Documentation - Add a "storage" reference document ([#15954](astral-sh/uv#15954)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Fix --default flag for pre-release Python versions

c19de3d

Use installation.satisfies() instead of matches_installation() when --default is used, allowing pre-release versions like 3.15.0a1 to be set as default when requested.

zanieb reviewed Nov 12, 2025

View reviewed changes

crates/uv/src/commands/python/install.rs Outdated Show resolved Hide resolved

nooscraft added 3 commits November 12, 2025 21:16

Fix clippy warning: use let-else instead of match

b35c9e9

Simplify default links check when --default is used

2ea66f8

When --default is used, only one request is allowed, so we can skip the installation matching check since all installations in the loop already match the request.

Fix formatting: move else clause to new line

15edbca

nooscraft added 2 commits November 12, 2025 23:31

Remove redundant first_request check

34ce084

When is_default_install is true, there's only one request and all installations in the loop already match that request, so the check is redundant.

Remove unused first_request variable

00b0798

zanieb reviewed Nov 12, 2025

View reviewed changes

nooscraft added 2 commits November 12, 2025 23:45

Use assert().success() and remove unnecessary cleanup

655a24e

Use assert().success() to ensure the command succeeds instead of silently skipping. Remove cleanup since tests run in isolated contexts.

Move test comment to doc comment above function

491455f

zanieb changed the title ~~Fix --default flag for pre-release Python versions~~ Fix handling of python install --default for pre-release Python versions Nov 12, 2025

zanieb approved these changes Nov 12, 2025

View reviewed changes

zanieb merged commit aec4254 into astral-sh:main Nov 12, 2025
99 checks passed

zanieb added bug Something isn't working preview Experimental behavior labels Nov 12, 2025

BrewTestBot mentioned this pull request Nov 17, 2025

uv 0.9.10 Homebrew/homebrew-core#254745

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Fix handling of `python install --default` for pre-release Python versions#16706

Fix handling of `python install --default` for pre-release Python versions#16706
zanieb merged 8 commits intoastral-sh:mainfrom
nooscraft:fix-default-prerelease

nooscraft commented Nov 12, 2025

Uh oh!

Uh oh!

zanieb commented Nov 12, 2025

Uh oh!

nooscraft commented Nov 12, 2025

Uh oh!

zanieb Nov 12, 2025

Uh oh!

nooscraft Nov 12, 2025

Uh oh!

zanieb Nov 12, 2025

Uh oh!

nooscraft Nov 12, 2025

Uh oh!

zanieb Nov 12, 2025

Uh oh!

nooscraft Nov 12, 2025

Uh oh!

zanieb commented Nov 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		// Clean up
		let _ = context.python_uninstall().arg("--all").output();

Comments

Conversation

nooscraft commented Nov 12, 2025

Summary

Test Plan

Uh oh!

Uh oh!

zanieb commented Nov 12, 2025

Uh oh!

nooscraft commented Nov 12, 2025

Uh oh!

zanieb Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

nooscraft Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

zanieb Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

nooscraft Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

zanieb Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

nooscraft Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

zanieb commented Nov 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants