Replace println with Printer for all dir commands & workspace dir followups#16690
Merged
Replace println with Printer for all dir commands & workspace dir followups#16690
dir commands & workspace dir followups#16690Conversation
Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
mikaylathompson
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
Member
|
I wonder if we should ban |
zanieb
pushed a commit
that referenced
this pull request
Nov 12, 2025
Follow-up from #16690, in `uv` every command should be using `write!(...)/writeln!(...)` with the `Printer` abstraction instead of bypassing control with the standard printing functions. This lint ensures that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv workspace dircommand #16678 that println should be replaced by usingprinter. Theprintlnpattern was pretty consistent across all thedircommands, so I've updated all of them in this PR (there are some usages ofprintlnoutside ofuv/src/commandsthat I didn't touch -- the use cases there seemed more complex and nuanced).Test Plan
No behavior changes, existing tests for all commands pass.