Merged
Conversation
83d8f8a to
8658f99
Compare
Signed-off-by: Mikayla Thompson <[email protected]>
f602976 to
aaca6e5
Compare
311c99d to
98bcecf
Compare
Signed-off-by: Mikayla Thompson <[email protected]>
98bcecf to
8401729
Compare
Signed-off-by: Mikayla Thompson <[email protected]>
zanieb
reviewed
Nov 11, 2025
zanieb
reviewed
Nov 11, 2025
| preview: Preview, | ||
| printer: Printer, | ||
| ) -> Result<ExitStatus> { | ||
| if preview.is_enabled(PreviewFeatures::WORKSPACE_METADATA) { |
Member
There was a problem hiding this comment.
I think this should be a separate preview flag so we can stabilize things separately
zanieb
reviewed
Nov 11, 2025
zanieb
reviewed
Nov 11, 2025
zanieb
reviewed
Nov 11, 2025
zanieb
reviewed
Nov 11, 2025
zanieb
reviewed
Nov 11, 2025
| @@ -6853,11 +6853,20 @@ pub enum WorkspaceCommand { | |||
| /// Display package metadata. | |||
Member
There was a problem hiding this comment.
(My own doc here is bad, I should fix that)
zanieb
reviewed
Nov 11, 2025
zanieb
approved these changes
Nov 11, 2025
Co-authored-by: Zanie Blue <[email protected]>
CodSpeed Performance ReportMerging #16678 will not alter performanceComparing Summary
|
Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
Signed-off-by: Mikayla Thompson <[email protected]>
konstin
reviewed
Nov 11, 2025
Comment on lines
+32
to
+41
| let dir: &Path = match package_name { | ||
| None => workspace.install_path().as_path(), | ||
| Some(package) => { | ||
| if let Some(p) = workspace.packages().get(&package) { | ||
| p.root().as_path() | ||
| } else { | ||
| bail!("Package `{package}` not found in workspace.") | ||
| } | ||
| } | ||
| }; |
Member
There was a problem hiding this comment.
This code compiles without the type cast:
Suggested change
| let dir: &Path = match package_name { | |
| None => workspace.install_path().as_path(), | |
| Some(package) => { | |
| if let Some(p) = workspace.packages().get(&package) { | |
| p.root().as_path() | |
| } else { | |
| bail!("Package `{package}` not found in workspace.") | |
| } | |
| } | |
| }; | |
| let dir = match package_name { | |
| None => workspace.install_path(), | |
| Some(package) => { | |
| if let Some(p) = workspace.packages().get(&package) { | |
| p.root() | |
| } else { | |
| bail!("Package `{package}` not found in workspace.") | |
| } | |
| } | |
| }; |
| ); | ||
| } | ||
|
|
||
| // Workspace dir output when run with `--package` |
Member
There was a problem hiding this comment.
nit:
Suggested change
| // Workspace dir output when run with `--package` | |
| /// Workspace dir output when run with `--package`. |
Signed-off-by: Mikayla Thompson <[email protected]>
zanieb
pushed a commit
that referenced
this pull request
Nov 11, 2025
…ollowups (#16690) ## Summary 1. Discussed in review of #16678 that println should be replaced by using `printer`. The `println` pattern was pretty consistent across all the `dir` commands, so I've updated all of them in this PR (there are some usages of `println` outside of `uv/src/commands` that I didn't touch -- the use cases there seemed more complex and nuanced). 2. I missed two comments in the previous PR before merging, so updates from those are in here as well. ## Test Plan No behavior changes, existing tests for all commands pass. --------- Signed-off-by: Mikayla Thompson <[email protected]>
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 14, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.9.8` -> `0.9.9` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.9.9`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#099) [Compare Source](astral-sh/uv@0.9.8...0.9.9) Released on 2025-11-12. ##### Deprecations - Deprecate use of `--project` in `uv init` ([#​16674](astral-sh/uv#16674)) ##### Enhancements - Add iOS support to Python interpreter discovery ([#​16686](astral-sh/uv#16686)) - Reject ambiguously parsed URLs ([#​16622](astral-sh/uv#16622)) - Allow explicit values in `uv version --bump` ([#​16555](astral-sh/uv#16555)) - Warn on use of managed pre-release Python versions when a stable version is available ([#​16619](astral-sh/uv#16619)) - Allow signing trampolines on Windows by using `.rcdata` to store metadata ([#​15068](astral-sh/uv#15068)) - Add `--only-emit-workspace` and similar variants to `uv export` ([#​16681](astral-sh/uv#16681)) ##### Preview features - Add `uv workspace dir` command ([#​16678](astral-sh/uv#16678)) - Add `uv workspace metadata` command ([#​16516](astral-sh/uv#16516)) ##### Configuration - Add `UV_NO_DEFAULT_GROUPS` environment variable ([#​16645](astral-sh/uv#16645)) ##### Bug fixes - Remove `torch-model-archiver` and `torch-tb-profiler` from PyTorch backend ([#​16655](astral-sh/uv#16655)) - Fix Pixi environment detection ([#​16585](astral-sh/uv#16585)) ##### Documentation - Fix `CMD` path in FastAPI Dockerfile ([#​16701](astral-sh/uv#16701)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNzMuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE3My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #13636
Prints the path to the workspace root by default, and any of the child packages if requested.
It has a preview flag like
workspace metadata, calledworkspace-dir.Summary
Test Plan
Unit tests added.