Merged
Conversation
Collaborator
Author
|
Please ignore the docker failures as its due to my depot OIDC configuration. |
samypr100
force-pushed
the
ssl-cert-dir
branch
from
d551355 to
483704f
Compare
samypr100
commented
Oct 29, 2025
samypr100
commented
Oct 29, 2025
samypr100
commented
Oct 29, 2025
samypr100
commented
Oct 29, 2025
samypr100
force-pushed
the
ssl-cert-dir
branch
5 times, most recently
from
23b0c80 to
0a1ccef
Compare
samypr100
commented
Oct 30, 2025
samypr100
force-pushed
the
ssl-cert-dir
branch
from
0a1ccef to
a31e937
Compare
samypr100
added
the
enhancement
samypr100
force-pushed
the
ssl-cert-dir
branch
4 times, most recently
from
da9adb1 to
8acabca
Compare
samypr100
force-pushed
the
ssl-cert-dir
branch
4 times, most recently
from
9ced871 to
5d19d0b
Compare
CodSpeed Performance ReportMerging #16473 will not alter performanceComparing Summary
|
zanieb
reviewed
Nov 11, 2025
zanieb
reviewed
Nov 11, 2025
zanieb
reviewed
Nov 11, 2025
zanieb
reviewed
Nov 11, 2025
zanieb
reviewed
Nov 11, 2025
zanieb
approved these changes
Nov 11, 2025
samypr100
force-pushed
the
ssl-cert-dir
branch
2 times, most recently
from
96c6e9f to
6f9065b
Compare
konstin
reviewed
Nov 12, 2025
samypr100
force-pushed
the
ssl-cert-dir
branch
from
2b94775 to
e2567ae
Compare
zanieb
reviewed
Nov 12, 2025
zanieb
reviewed
Nov 12, 2025
samypr100
force-pushed
the
ssl-cert-dir
branch
from
d331673 to
013385f
Compare
This was referenced Nov 12, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 18, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.9.9` -> `0.9.10` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.9.10`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0910) [Compare Source](astral-sh/uv@0.9.9...0.9.10) Released on 2025-11-17. ##### Enhancements - Add support for `SSL_CERT_DIR` ([#​16473](astral-sh/uv#16473)) - Enforce UTF‑8-encoded license files during `uv build` ([#​16699](astral-sh/uv#16699)) - Error when a `project.license-files` glob matches nothing ([#​16697](astral-sh/uv#16697)) - `pip install --target` (and `sync`) install Python if necessary ([#​16694](astral-sh/uv#16694)) - Account for `python_downloads_json_url` in pre-release Python version warnings ([#​16737](astral-sh/uv#16737)) - Support HTTP/HTTPS URLs in `uv python --python-downloads-json-url` ([#​16542](astral-sh/uv#16542)) ##### Preview features - Add support for `--upgrade` in `uv python install` ([#​16676](astral-sh/uv#16676)) - Fix handling of `python install --default` for pre-release Python versions ([#​16706](astral-sh/uv#16706)) - Add `uv workspace list` to list workspace members ([#​16691](astral-sh/uv#16691)) ##### Bug fixes - Don't check file URLs for ambiguously parsed credentials ([#​16759](astral-sh/uv#16759)) ##### Documentation - Add a "storage" reference document ([#​15954](astral-sh/uv#15954)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNzMuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE3My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
|
This really looks like openssl-probe reinvented. It does already the env var magic. I am confused why uv has to reproduce it?! uv does use openssl-probe. |
Collaborator
Author
I'm don't think this is correct as stated as uv does not use openssl-probe by default. It's opt-in when the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #16414
Adds support for the standard SSL_CERT_DIR which has gained recent proper support from rustls-native-certs in v0.8.2.
In addition, this PR clarifies documentation around
SSL_CERT_FILEandSSL_CERT_DIRwhen used in combination withUV_NATIVE_TLSas mentioned in #16412 (comment)Test Plan
Manually tested with custom cert chains in multiple directories and loading them via SSL_CERT_DIR. We didn't have tests for
SSL_CERT_FILEorSSL_CERT_DIRenvironment variables so I added a basic one using our own test-only certificate generation and dummy https server. I also moved some things around for better reuse.