Skip to content

Comments

Upgrade reqsign to 0.18.0 to remove chrono deps#16172

Merged
charliermarsh merged 1 commit intoastral-sh:mainfrom
tisonkun:reqsign-018
Oct 8, 2025
Merged

Upgrade reqsign to 0.18.0 to remove chrono deps#16172
charliermarsh merged 1 commit intoastral-sh:mainfrom
tisonkun:reqsign-018

Conversation

@tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Oct 8, 2025

This follows up #15925.

cc @BurntSushi @charliermarsh

@charliermarsh
Copy link
Member

Woahh amazing, thank you!

@tisonkun
Copy link
Contributor Author

tisonkun commented Oct 8, 2025

Error: missing API token, please run depot login

Seems CI failure is unrelated to this patch but my own environment doesn't have the token.

Could you give a review? I think this is a relatively tiny one :D

@konstin konstin changed the title Upgrade resign to 0.18.0 to remove chrono deps Upgrade reqsign to 0.18.0 to remove chrono deps Oct 8, 2025
@konstin konstin added the internal A refactor or improvement that is not user-facing label Oct 8, 2025
@konstin
Copy link
Member

konstin commented Oct 8, 2025

Seems CI failure is unrelated to this patch but my own environment doesn't have the token.

It's a problem with a CI provider, it affects all CI runs atm.

@tisonkun
Copy link
Contributor Author

tisonkun commented Oct 8, 2025

@konstin, shall we merge this patch since the failure is unrelated? Or wait for some other conditions?

@konstin konstin requested a review from charliermarsh October 8, 2025 13:10
@charliermarsh
Copy link
Member

I'll test the upgrade locally, then merge.

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM.

@charliermarsh charliermarsh merged commit aadf103 into astral-sh:main Oct 8, 2025
160 of 200 checks passed
@tisonkun tisonkun deleted the reqsign-018 branch October 8, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants