Fix uv sync accidentally retaining editables#15450
Closed
charliermarsh wants to merge 4 commits intomainfrom
Closed
Fix uv sync accidentally retaining editables#15450charliermarsh wants to merge 4 commits intomainfrom
uv sync accidentally retaining editables#15450charliermarsh wants to merge 4 commits intomainfrom
Conversation
- Added logic to force reinstall URL-based packages when `--no-sources` is specified, ensuring they are replaced with registry versions. - Updated the `do_sync` function to handle the reinstall logic based on the presence of URL-based packages in the environment. - Introduced a new test to verify the correct transition from editable to package installation when using the `--no-sources` flag, addressing Issue #15190. This change improves the reliability of package installations in environments where source installations are disabled.
- Updated the logic to selectively reinstall URL-based packages only when the resolution selects a registry distribution, preventing unnecessary reinstalls for packages specified via direct URL. - Enhanced debug logging for better clarity on package evaluation during the reinstall process. - Adjusted related test expectations to reflect the changes in package installation behavior. This change improves the efficiency of package management when source installations are disabled.
charliermarsh
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
Member
Author
|
Closing in favor of #15234. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #15190.