Add `extra-build-dependencies` hint for any missing module on build failure by blueraft · Pull Request #15252 · astral-sh/uv

blueraft · 2025-08-13T16:00:39Z

Alternative to #15251.

As suggested in #15118 (comment)

Test Plan

cargo test

… package. Add additional hints for `pip` and `setuptools`

zanieb · 2025-08-13T20:11:12Z

Sorry I broke main!

zanieb · 2025-08-13T20:29:07Z

I think you can test this with something like

uv/crates/uv/tests/it/sync.rs

Lines 1571 to 1601 in 323aa8f

    
           fn sync_extra_build_dependencies() -> Result<()> { 
        
               let context = TestContext::new("3.12").with_filtered_counts(); 
        
               // Write a test package that arbitrarily requires `anyio` at build time 
        
               let child = context.temp_dir.child("child"); 
        
               child.create_dir_all()?; 
        
               let child_pyproject_toml = child.child("pyproject.toml"); 
        
               child_pyproject_toml.write_str(indoc! {r#" 
        
                   [project] 
        
                   name = "child" 
        
                   version = "0.1.0" 
        
                   requires-python = ">=3.9" 
        
                   [build-system] 
        
                   requires = ["hatchling"] 
        
                   backend-path = ["."] 
        
                   build-backend = "build_backend" 
        
               "#})?; 
        
               let build_backend = child.child("build_backend.py"); 
        
               build_backend.write_str(indoc! {r#" 
        
                   import sys 
        
                   from hatchling.build import * 
        
                   try: 
        
                       import anyio 
        
                   except ModuleNotFoundError: 
        
                       print("Missing `anyio` module", file=sys.stderr) 
        
                       sys.exit(1) 
        
               "#})?; 
        
               child.child("src/child/__init__.py").touch()?;

crates/uv/tests/it/sync.rs

crates/uv-build-frontend/src/error.rs

charliermarsh · 2025-08-14T11:22:31Z

I'm a little worried about the impact it will have on binary size, did you check a release build before and after?

blueraft · 2025-08-14T12:10:34Z

did you check a release build before and after?

Not much of an increase, only 32kbs more

❯ du -sk uv_with_pipreqs
45240   uv_with_pipreqs
❯ du -sk uv_without_pepreqs
45208   uv_without_pepreqs

zanieb · 2025-08-14T13:06:09Z

crates/uv/tests/it/pip_install.rs

+          [tool.uv.extra-build-dependencies]
+          "anyio" = ["setuptools"]
+
+          or `uv pip install setuptools` into the environment and re-run with `--no-build-isolation`.


Fwiw this instruction isn't sufficient, because then they also need to install all of the other build dependencies of anyio. I'm hesitant to suggest it without that additional information (and broadly hesitant to suggest it at all).

Yeah I thought about this, but this matches the current hint we give for people facing issues with torch so I figured we shouldn't remove that.

I think now that we have the extra build dependencies it's actually okay to remove that, but... I'm okay with considering that separately. Can you open a tracking issue?

crates/uv/tests/it/pip_install.rs

crates/uv-build-frontend/src/error.rs

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.8.9` -> `0.8.11` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.8.11`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0811) [Compare Source](astral-sh/uv@0.8.10...0.8.11) ##### Python - Add Python 3.14.0rc2 - Update Pyodide to 0.28.1 ##### Enhancements - Add Debian 13 trixie to published Docker images ([#15269](astral-sh/uv#15269)) - Add `extra-build-dependencies` hint for any missing module on build failure ([#15252](astral-sh/uv#15252)) - Make 'v' prefix cyan in overlap warnings ([#15259](astral-sh/uv#15259)) ##### Bug fixes - Fix missing uv version in extended Docker image tags ([#15263](astral-sh/uv#15263)) - Persist cache info when re-installing cached wheels ([#15274](astral-sh/uv#15274)) ##### Rust API - Allow passing custom `reqwest` clients to `RegistryClient` ([#15281](astral-sh/uv#15281)) ### [`v0.8.10`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0810) [Compare Source](astral-sh/uv@0.8.9...0.8.10) ##### Python - Add support for installing Pyodide versions ([#14518](astral-sh/uv#14518)) ##### Enhancements - Allow Python requests with missing segments, e.g., just `aarch64` ([#14399](astral-sh/uv#14399)) ##### Preview - Move warnings for conflicting modules into preview ([#15253](astral-sh/uv#15253)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

blueraft force-pushed the use-pipreqs-build-error-hints branch from 27cd247 to c9459e3 Compare August 13, 2025 16:45

blueraft and others added 7 commits August 13, 2025 22:08

Hint to use extra-build-depedencies when build fails with a missing…

fbd3fbd

… package. Add additional hints for `pip` and `setuptools`

Implement an auto-import proof-of-concept

6807198

Move pipreqs to uv-build-frontend

0b4c4e4

Simplify ModuleNotFoundError handling with generic regex

9dd0557

Exclude pipreqs-mapping from typos

d37beeb

Add ModuleNotFoundError to the regex

f7b3653

Fix tests

d9940bd

blueraft force-pushed the use-pipreqs-build-error-hints branch from c9459e3 to d9940bd Compare August 13, 2025 20:08

Typo in typos

4eb0c81

zanieb reviewed Aug 13, 2025

View reviewed changes

crates/uv/tests/it/sync.rs Outdated Show resolved Hide resolved

Test for module mapping and normalize packagen ame

feb3b95

zanieb reviewed Aug 13, 2025

View reviewed changes

crates/uv-build-frontend/src/error.rs Outdated Show resolved Hide resolved

zanieb mentioned this pull request Aug 13, 2025

Hint to use extra-build-depedencies when build fails with a missing… #15251

Closed

Change package name parsing

4bfaba7

Clippy

db42f29

zanieb reviewed Aug 14, 2025

View reviewed changes

crates/uv/tests/it/pip_install.rs Outdated Show resolved Hide resolved

zanieb reviewed Aug 14, 2025

View reviewed changes

crates/uv-build-frontend/src/error.rs Outdated Show resolved Hide resolved

Review feedback

c289a02

blueraft mentioned this pull request Aug 14, 2025

Remove uv pip install hint for build dep module not found errors #15283

Open

Fix tests

9fec953

zanieb changed the title ~~Add pipreqs module-to-package mapping for build time ModuleNotFoundError hints~~ Add extra-build-dependencies hint for any missing module on build failure Aug 14, 2025

zanieb merged commit e7b55fe into astral-sh:main Aug 14, 2025
117 of 153 checks passed

BrewTestBot mentioned this pull request Aug 14, 2025

uv 0.8.11 Homebrew/homebrew-core#233569

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Add `extra-build-dependencies` hint for any missing module on build failure#15252

Add `extra-build-dependencies` hint for any missing module on build failure#15252
zanieb merged 13 commits intoastral-sh:mainfrom
blueraft:use-pipreqs-build-error-hints

blueraft commented Aug 13, 2025 •

edited

Loading

Uh oh!

zanieb commented Aug 13, 2025

Uh oh!

zanieb commented Aug 13, 2025

Uh oh!

Uh oh!

Uh oh!

charliermarsh commented Aug 14, 2025

Uh oh!

blueraft commented Aug 14, 2025

Uh oh!

zanieb Aug 14, 2025

Uh oh!

blueraft Aug 14, 2025

Uh oh!

zanieb Aug 14, 2025

Uh oh!

blueraft Aug 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

blueraft commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Plan

Uh oh!

zanieb commented Aug 13, 2025

Uh oh!

zanieb commented Aug 13, 2025

Uh oh!

Uh oh!

Uh oh!

charliermarsh commented Aug 14, 2025

Uh oh!

blueraft commented Aug 14, 2025

Uh oh!

zanieb Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

blueraft Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

zanieb Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

blueraft Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

blueraft commented Aug 13, 2025 •

edited

Loading