chore(ci): address lint findings in build-docker.yml#15245
Merged
Conversation
Signed-off-by: William Woodruff <[email protected]>
woodruffw
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
Member
|
Just fyi we don't really have a release dry-run option here. We'll run the Docker builds in the pull request, but we can't test annotating publishes without publishing. |
Member
Author
Gotcha, OK -- in that case I don't have a great way to test my reusable workflow permissions theory 😅. However, I cross-checked that the permissions are consistent here: uv/.github/workflows/release.yml Lines 112 to 116 in 959c952 So I think this is good to go. |
zanieb
approved these changes
Aug 12, 2025
This was referenced Aug 13, 2025
zanieb
added a commit
that referenced
this pull request
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This re-creates #15145, with fixes following the revert in #15174.
The overall approach is the same, except that I've added an explicit permissions block to
docker-annotate-basethat should cover the needed permissions in that job.(One confusion is around how that wasn't failing before -- FWICT it was receiving the default
GITHUB_TOKEN, which doesn't includeid-token: writeorpackages: write. So it should have been failing even before I explicitly didpermissions: {}...)Edit: Oh, I see why -- the actual release process does a
workflow_call, so this inherits itsGITHUB_TOKENfromrelease.yml:custom-build-docker, which in turn has the right permissions granted to it.Test Plan
See what happens in CI. Plus maybe we could do a release dry-run?