Refactor os, arch, and libc information into a shared Platform type#15027
Merged
Refactor os, arch, and libc information into a shared Platform type#15027
Platform type#15027Conversation
03aff1f to
4781989
Compare
4781989 to
2d617a8
Compare
2d617a8 to
f6f04df
Compare
2741e1c to
d93f546
Compare
d93f546 to
1dc64af
Compare
1dc64af to
e88b548
Compare
0c4febc to
08f7c81
Compare
0e07899 to
a203c1f
Compare
c9329db to
0b21a9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses this outstanding item from a previous review #13724 (comment)
I'm interested in this now for consolidating some logic in #12731