Symlink (or copy) binary entry points into ephemeral environments#14877
Draft
Symlink (or copy) binary entry points into ephemeral environments#14877
Conversation
zanieb
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/link-entrypoints
branch
from
778a833 to
c7982af
Compare
zanieb
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
Contributor
|
One think to think about with a copy is that executable-relative dependencies will break. This will be fine for symlinks, and so in particular |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14874
In addition to copying entry points and rewriting their shebangs, if we encounter entry points that do not have shebangs (e.g., binaries), we'll symlink (or copy, on Windows) them into the directory.
I'm uncertain if this is the correct approach or if we should change binary discovery in Ruff to account for this case.